Date: Sat, 4 Feb 2023 11:12:34 -0700 From: Warner Losh <imp@bsdimp.com> To: Brooks Davis <brooks@freebsd.org> Cc: freebsd-git <freebsd-git@freebsd.org> Subject: Re: Proposed Github Pull Request Policy Message-ID: <CANCZdfox%2Bbd1nRZDgkOhy57TW=UasAjVX_MnrBwOep55CftCog@mail.gmail.com> In-Reply-To: <Y905cVvlrQ5YPqgA@spindle.one-eyed-alien.net> References: <CANCZdfq_=pDon8LmhjV%2BWyPsGcuG1hp3LrfxXe9mJ51J0P2iqg@mail.gmail.com> <Y905cVvlrQ5YPqgA@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Fri, Feb 3, 2023 at 9:42 AM Brooks Davis <brooks@freebsd.org> wrote: > On Thu, Feb 02, 2023 at 07:12:29PM -0700, Warner Losh wrote: > > Geetngs, > > > > I'd like to put some parameters around the pull requests on github. To > that > > end, I'd like us to consider the following policy: > > This seems like a good start. > > > Pull requests shouldn't expand in scope in response to feedback: If the > > feedback suggests a new series of changes, please create a new pull > > requests. > > I think I'd prefer: "Pull requests shouldn't expand in scope once > created:...". > > Some direction on using rebase and forced push when addressing feedback is > probably also in order. If I'm taking a few minutes to look at a PR that > caught my eye I don't want to wade through a bunch of fixups. > I've written this up as https://reviews.freebsd.org/D38382 which I'm open to feedback on. Especially other areas of the docs that need to be fixed to be consistent. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 3, 2023 at 9:42 AM Brooks Davis <<a href="mailto:brooks@freebsd.org">brooks@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, Feb 02, 2023 at 07:12:29PM -0700, Warner Losh wrote:<br> > Geetngs,<br> > <br> > I'd like to put some parameters around the pull requests on github. To that<br> > end, I'd like us to consider the following policy:<br> <br> This seems like a good start.<br> <br> > Pull requests shouldn't expand in scope in response to feedback: If the<br> > feedback suggests a new series of changes, please create a new pull<br> > requests.<br> <br> I think I'd prefer: "Pull requests shouldn't expand in scope once<br> created:...".<br> <br> Some direction on using rebase and forced push when addressing feedback is<br> probably also in order. If I'm taking a few minutes to look at a PR that<br> caught my eye I don't want to wade through a bunch of fixups.<br></blockquote><div><br></div><div>I've written this up as <a href="https://reviews.freebsd.org/D38382">https://reviews.freebsd.org/D38382</a>; which I'm open to feedback on. Especially other areas of the docs that need to be fixed to be consistent.</div><div><br></div><div>Warner<br> </div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfox%2Bbd1nRZDgkOhy57TW=UasAjVX_MnrBwOep55CftCog>