Date: Thu, 01 Jun 2023 16:42:42 +0000 From: bugzilla-noreply@freebsd.org To: sysinstall@FreeBSD.org Subject: [Bug 204506] bsdinstall(8) umount target should be able to unmount zfs filesystems Message-ID: <bug-204506-8135-kyeKUZDo5R@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-204506-8135@https.bugs.freebsd.org/bugzilla/> References: <bug-204506-8135@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D204506 Jonathan Reynolds <jreynolds1729@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jreynolds1729@gmail.com --- Comment #7 from Jonathan Reynolds <jreynolds1729@gmail.com> --- This still happens on 14-CURRENT. The issue: /usr/libexec/bsdinstall/umount fails if fstab is emtpty, which happens with= ZFS + BIOS boot. Two dialog box displaying /tmp/bsdinstall_log will be shown in succession (= user input required). The installation itself does succeed. Simple fix (main 9a49a3792940497ddf4657f6e5be56d8ef881edc): --- usr.sbin/bsdinstall/scripts/umount.orig 2023-06-01 18:17:39.4829440= 00 +0200 +++ usr.sbin/bsdinstall/scripts/umount 2023-06-01 18:18:20.275423000 +0200 @@ -46,6 +46,6 @@ }' > $TMP_FSTAB umount $BSDINSTALL_CHROOT/dev 2>/dev/null -if [ -n "$TMP_FSTAB" ]; then +if [ -n "$TMP_FSTAB" -a -s "$TMP_FSTAB" ]; then umount -F $TMP_FSTAB -a 2>/dev/null fi Note: The described issue does not happen if $debugFile is prepended with a plus = `+' sign. if $debugFile is prepended with a `+' in /etc/rc.local and the `+' sign is removed in /etc/installerconfig, the script will show one dialog box displa= ying /tmp/bsdinstall_log and an other showing success/reboot. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-204506-8135-kyeKUZDo5R>