Date: Mon, 26 Feb 2024 16:25:45 +0000 From: Igor Ostapenko <igor.ostapenko@pm.me> To: Paul Floyd <paulf2718@gmail.com> Cc: freebsd-hackers@freebsd.org Subject: Re: Add jail execution environment support to the FreeBSD test suite Message-ID: <p1gWDrJkoYRyleu_fr9Sj4M4G68SXbats7uxlQLuQNm0uIn3hrGP5Sf4x9VsRyvEHouVbVHB_6H0KOAz9JfYCwiNvIHFY5F9u13tYmcZoyA=@pm.me> In-Reply-To: <bda8840f-5450-48c8-9721-cc782c2c98ac@gmail.com> References: <2bjQNp1msrv-_AqyamMun6kY-SCqbgPm3Q7DqVQHAYlqvFkiE1i85svfIT-QQdUG1cg3cKippyTyv8Z-5nbLu4WaMutgZQ7KT-YYo_5Pbro=@pm.me> <188b3537-11b1-4169-aae2-070d349b6016@gmail.com> <5XGsuxCWojiK7f1wBuoC73PWMtjVB3oCvsy1vHQtNr5UHC_2LN8zNGczKwpQEs4Pcc8g1G3Rir4uIrQ9iUxKbWmonsEu5f_mHzldy4vuYk4=@pm.me> <bda8840f-5450-48c8-9721-cc782c2c98ac@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, February 23rd, 2024 at 7:57 PM, Paul Floyd <paulf2718@gmail.com> wrote: > On 23-02-24 16:08, Igor Ostapenko wrote: > > > On Friday, February 23rd, 2024 at 10:30 AM, Paul Floyd paulf2718@gmail.com wrote: > > > > > Will there be an option to turn this off globally? > > > > > > I sometimes run test suits with Valgrind. I'm not aware of any option to > > > do that cleanly so I just do it with brute force: run kyua and all > > > children under Valgrind. > > > > > > valgrind --trace-children=yes -q kyua test -k Kyuafile > > > > > > Adding jails into the mix is likely to give worse results. I did try > > > using an x86 jail as an alternative to VirtualBox but I gave up as I got > > > too many test failures. > > > > Thanks for your attention and mention of your use case. > > > > I've added this point to my TODO. I guess it could look as the following: > > > > valgrind --trace-children=yes -q kyua -v execenv=host test -k Kyuafile > > > Sounds good, but I'd need to test in order to make sure. I don't run > that kind of test very often. > > > Does it look like something that would cover your production needs? > > > It's not to test FreeBSD for prod, it's to test Valgrind is working with > all those tests (any FreeBSD errors picked up are a bonus). > Paul, it would be appreciated if you have time to test the patch. The general test plan is covered here: https://reviews.freebsd.org/D42350, but specifically for your case the following extra check could be run in addition: valgrind --trace-children=yes -q kyua -v execenv=host test -k /usr/tests/sys/netpfil/pf/Kyuafile It should report that pass_block:* tests are skipped due to the given "-v execenv=host" runtime configuration. I hope current implementation meets your expectations. Best regards, Igor.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p1gWDrJkoYRyleu_fr9Sj4M4G68SXbats7uxlQLuQNm0uIn3hrGP5Sf4x9VsRyvEHouVbVHB_6H0KOAz9JfYCwiNvIHFY5F9u13tYmcZoyA=>