Date: Mon, 27 Apr 2026 01:07:32 +0100 From: Oliver Pinter <oliver.pntr@gmail.com> To: "Simon J. Gerraty" <sjg@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 566cc005812b - main - safe_set treat ':' and '#' differently Message-ID: <CAPjTQNH4UzH30skX2FObaOurpDGGP2Y4n4meKLVLVAzWr3dhYQ@mail.gmail.com> In-Reply-To: <69e8f964.39869.24418b55@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hi! Do you have unit tests for these? Have a nice day, op On Wednesday, April 22, 2026, Simon J. Gerraty <sjg@freebsd.org> wrote: > The branch main has been updated by sjg: > > URL: https://cgit.FreeBSD.org/src/commit/?id= > 566cc005812b72a4ba236764651dd8e82c94a166 > > commit 566cc005812b72a4ba236764651dd8e82c94a166 > Author: Simon J. Gerraty <sjg@FreeBSD.org> > AuthorDate: 2026-04-22 16:37:35 +0000 > Commit: Simon J. Gerraty <sjg@FreeBSD.org> > CommitDate: 2026-04-22 16:37:35 +0000 > > safe_set treat ':' and '#' differently > > Treat '#' as a comment anywhere, > but ':' only at start of line. > --- > libexec/rc/safe_eval.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libexec/rc/safe_eval.sh b/libexec/rc/safe_eval.sh > index f96c34dda936..3b3241ae821d 100644 > --- a/libexec/rc/safe_eval.sh > +++ b/libexec/rc/safe_eval.sh > @@ -1,6 +1,6 @@ > : > # RCSid: > -# $Id: safe_eval.sh,v 1.27 2026/04/22 16:11:57 sjg Exp $ > +# $Id: safe_eval.sh,v 1.28 2026/04/22 16:36:32 sjg Exp $ > # > # @(#) Copyright (c) 2023-2026 Simon J. Gerraty > # > @@ -32,7 +32,7 @@ fi > # "xtras" should be used with caution and cannot include ';' > # > safe_set() { > - ${SED:-sed} 's/^[ ]*//;s/^[:#].*//;/^[A-Za-z_][ > A-Za-z0-9_]*=/!d;s;[^A-Za-z0-9_. "'"$1"'$,/=:+-];_;g' > + ${SED:-sed} 's/^[ ]*//;s/[ ]*#.*//;s/^:.*//;/^[A-Za-z_][ > A-Za-z0-9_]*=/!d;s;[^A-Za-z0-9_. "'"$1"'$,/=:+-];_;g' > } > > ## > > [-- Attachment #2 --] Hi!<div><br></div><div>Do you have unit tests for these?</div><div><br></div><div>Have a nice day,</div><div>op<br><br>On Wednesday, April 22, 2026, Simon J. Gerraty <<a href="mailto:sjg@freebsd.org">sjg@freebsd.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The branch main has been updated by sjg:<br> <br> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=566cc005812b72a4ba236764651dd8e82c94a166" target="_blank">https://cgit.FreeBSD.org/src/<wbr>commit/?id=<wbr>566cc005812b72a4ba236764651dd8<wbr>e82c94a166</a><br>; <br> commit 566cc005812b72a4ba236764651dd8<wbr>e82c94a166<br> Author: Simon J. Gerraty <sjg@FreeBSD.org><br> AuthorDate: 2026-04-22 16:37:35 +0000<br> Commit: Simon J. Gerraty <sjg@FreeBSD.org><br> CommitDate: 2026-04-22 16:37:35 +0000<br> <br> safe_set treat ':' and '#' differently<br> <br> Treat '#' as a comment anywhere,<br> but ':' only at start of line.<br> ---<br> libexec/rc/safe_eval.sh | 4 ++--<br> 1 file changed, 2 insertions(+), 2 deletions(-)<br> <br> diff --git a/libexec/rc/safe_eval.sh b/libexec/rc/safe_eval.sh<br> index f96c34dda936..3b3241ae821d 100644<br> --- a/libexec/rc/safe_eval.sh<br> +++ b/libexec/rc/safe_eval.sh<br> @@ -1,6 +1,6 @@<br> :<br> # RCSid:<br> -# $Id: safe_eval.sh,v 1.27 2026/04/22 16:11:57 sjg Exp $<br> +# $Id: safe_eval.sh,v 1.28 2026/04/22 16:36:32 sjg Exp $<br> #<br> # @(#) Copyright (c) 2023-2026 Simon J. Gerraty<br> #<br> @@ -32,7 +32,7 @@ fi<br> # "xtras" should be used with caution and cannot include ';'<br> # <br> safe_set() {<br> - ${SED:-sed} 's/^[ ]*//;s/^[:#].*//;/^[A-Za-z_][<wbr>A-Za-z0-9_]*=/!d;s;[^A-Za-z0-<wbr>9_. "'"$1"'$,/=:+-];_;g'<br> + ${SED:-sed} 's/^[ ]*//;s/[ ]*#.*//;s/^:.*//;/^[A-Za-z_][<wbr>A-Za-z0-9_]*=/!d;s;[^A-Za-z0-<wbr>9_. "'"$1"'$,/=:+-];_;g'<br> }<br> <br> ##<br> <br> </blockquote></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPjTQNH4UzH30skX2FObaOurpDGGP2Y4n4meKLVLVAzWr3dhYQ>