Date: Mon, 22 Jun 2026 00:41:11 +0000 From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Abdelkader Boudih <freebsd@seuros.com> Subject: git: 3ffd2baa268d - main - if_fwsubr: remove ARP target hardware address trimming Message-ID: <6a3884a7.39d81.30d68996@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=3ffd2baa268d298201d54c733dc0e635cc1dca9f commit 3ffd2baa268d298201d54c733dc0e635cc1dca9f Author: Abdelkader Boudih <freebsd@seuros.com> AuthorDate: 2026-06-22 00:31:29 +0000 Commit: Adrian Chadd <adrian@FreeBSD.org> CommitDate: 2026-06-22 00:31:34 +0000 if_fwsubr: remove ARP target hardware address trimming Per RFC 2734 section 5, the 1394 ARP packet is a fixed 32-octet structure with no target hardware address field. Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D57617 --- sys/net/if_fwsubr.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/sys/net/if_fwsubr.c b/sys/net/if_fwsubr.c index ceac93d31d56..07a065653649 100644 --- a/sys/net/if_fwsubr.c +++ b/sys/net/if_fwsubr.c @@ -180,13 +180,6 @@ firewire_output(struct ifnet *ifp, struct mbuf *m, const struct sockaddr *dst, ah->ar_hrd = htons(ARPHRD_IEEE1394); if (unicast) *destfw = *(struct fw_hwaddr *) ar_tha(ah); - - /* - * The standard arp code leaves a hole for the target - * hardware address which we need to close up. - */ - bcopy(ar_tpa(ah), ar_tha(ah), ah->ar_pln); - m_adj(m, -ah->ar_hln); break; } #endifhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a3884a7.39d81.30d68996>