Date: Wed, 8 Jul 2009 05:56:14 +0000 (UTC) From: Marcel Moolenaar <marcel@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/ata atapi-cd.c src/sys/geom geom_dev.c src/sys/geom/part g_part.c g_part_if.m src/sys/sys disk.h Message-ID: <200907080558.n685wIng085743@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
marcel 2009-07-08 05:56:14 UTC FreeBSD src repository Modified files: sys/dev/ata atapi-cd.c sys/geom geom_dev.c sys/geom/part g_part.c g_part_if.m sys/sys disk.h Log: SVN rev 195436 on 2009-07-08 05:56:14Z by marcel Revert revisions 188839 and 188868. Use of the ioctl in geom_dev.c is invalid because the ioctl happens without prior open. The ioctl got introduced to provide backward compatibility for extended partitions, but it ended up not being used because it didn't work as expected. Since there are no consumers of the ioctl and the implementation is broken, the best fix is to remove the code entirely. Spotted by: phk Approved by: re (kensmith) Revision Changes Path 1.206 +1 -4 src/sys/dev/ata/atapi-cd.c 1.102 +0 -12 src/sys/geom/geom_dev.c 1.39 +0 -28 src/sys/geom/part/g_part.c 1.9 +0 -9 src/sys/geom/part/g_part_if.m 1.45 +0 -6 src/sys/sys/disk.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907080558.n685wIng085743>