Date: Thu, 18 Dec 2008 01:29:43 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Robert Watson <rwatson@FreeBSD.org> Cc: src-committers@FreeBSD.org, jhb@FreeBSD.org, svn-src-all@FreeBSD.org, Max Laier <max@love2party.net>, svn-src-head@FreeBSD.org, =?ISO-8859-15?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Subject: Re: svn commit: r186187 - head/sys/net Message-ID: <20081218010226.K6569@delplex.bde.org> In-Reply-To: <alpine.BSF.1.10.0812171244310.75599@fledge.watson.org> References: <200812161703.mBGH3M7m042955@svn.freebsd.org> <200812161821.37686.max@love2party.net> <alpine.BSF.1.10.0812161751250.75599@fledge.watson.org> <86myevgley.fsf@ds4.des.no> <alpine.BSF.1.10.0812171244310.75599@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 17 Dec 2008, Robert Watson wrote: > On Wed, 17 Dec 2008, Dag-Erling Smørgrav wrote: > >> Robert Watson <rwatson@FreeBSD.org> writes: >>> exit(EX_OK); /* >>> * Avoid obvious comments such as >>> * "Exit 0 on success." >>> */ >> >> Umm, didn't we agree *not* to use sysexits? > > Dunno, that one is not mine: > > Annotations for style.9 > *************** > 1.5 (joerg 31-Mar-96): exit(EX_OK); /* > 1.38 (alex 28-Oct-00): exit(EX_USAGE); 1.5 is the original commit that added sysexits to style.9. It also broke the comment -- it is no longer obvious that exit(EX_OK) exits with status 0 on success. Also, reformatting the comment gave the bad example of a block comment to the right of the code. The original code instead gave an example of abnormally indenting the comment so as to fit it in 80 columns: %%% exit(0); /* Avoid obvious comments such as "Exit 0 on success." */ %%% The comment is indented to column 20 instead of the usual 40 or 32. The reformatting is part of another bug suite -- to coerce /usr/src/admin/style/style into a man page, 5 leading spaces had to be added for man page indentation. This required reformatting to keep fitting in 80 columns and messes up tabs. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081218010226.K6569>