Date: Wed, 30 May 2018 05:41:42 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Antoine Brodin <antoine@freebsd.org> Cc: Hans Petter Selasky <hps@selasky.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool Message-ID: <201805301241.w4UCfhoE071874@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CAALwa8n5Lc0fvP6ec2F8Bnc7BnVDP05VT1GUtD6hsVFg68U8Ow@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Wed, May 30, 2018 at 8:20 AM, Hans Petter Selasky <hps@selasky.org> wrote: > > On 05/30/18 10:02, Antoine Brodin wrote: > >> > >> Could the pcap/pcap.h header be fixed instead with #ifdef HAVE_REMOTE > >> as it previously had? > > > > > > The HAVE_REMOTE was removed upstream: > > > > https://github.com/the-tcpdump-group/libpcap/commit/a372536befc9b1ee1d355058daa2eb9f66aa0c59#diff-46964bcbd8e8a5cec9a75c66ab26a97b > > > > What do you think? Shall we re-add it to base? > > Either hide remote packet capture functions from the header or enable > remote capture functions? > Note that net/p5-Net-Pcap will fail to build with libpcap from ports > too when libpcap from ports is updated to version 1.9.0 (pre-release). If there is any thoughs of merging this to stable/11 wont the HAVE_REMOTE have to be turned on anyway? I suppose it get be #ifdef FreeBSD_VERSION. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805301241.w4UCfhoE071874>