Date: Tue, 23 Aug 2022 15:24:09 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: FreeBSD Mailing List <freebsd-ports@freebsd.org> Subject: Re: Patching Conditionally for 12.3 Releases Message-ID: <CAFDf7U%2BoEPsaNhEdRwd-9wTm=OU9b1G6gqpT7a_e%2BWg=dYpLKA@mail.gmail.com> In-Reply-To: <20220823092244.bxi5uyrzicuff5yy@nexus.home.palmen-it.de> References: <CAFDf7UJWajRPrv-Vkq6ZKKsFKbrv=%2BeXpucJL%2BjNdJkc7oePAg@mail.gmail.com> <20220823092244.bxi5uyrzicuff5yy@nexus.home.palmen-it.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000019805605e6e952cf
Content-Type: text/plain; charset="UTF-8"
Hi Felix,
Possible alternative without if:
>
> EXTRA_PATCHES= ${EXTRA_PATCHES_${OPSYS}}
> EXTRA_PATCHES_FreeBSD= ${${OSVERSION}<1300000:?${PATCHDIR}/extra-foo:}
>
It is nice without showing if condition but it becomes way more cryptic and
complex. It will be very nice if ports include OPSYS, OSVERSION, etc:
OPTIONS_DEFINE= FOO BAR
FOO_OSVERSION= > 1300000
BAR_OSVERSION= > 1200000 && < 1300000
FOO_EXTRA_PATCHES= ${PATCHDIR}/extra-patch-foo
BAR_EXTRA_PATCHES_OFF= ${PATCHDIR}/extra-patch-bar.c
It's solved this way :)
Cheers,
--
>
Nuno Teixeira
FreeBSD Committer (ports)
--00000000000019805605e6e952cf
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><div>Hi Felix,</div><div><br></div></div>=
<div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex=
">
Possible alternative without if:<br>
<br>
EXTRA_PATCHES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ${EXTRA_PATCHES_${OPSYS}=
}<br>
EXTRA_PATCHES_FreeBSD=3D=C2=A0 ${${OSVERSION}<1300000:?${PATCHDIR}/extra=
-foo:}<br>
</blockquote><div><br></div><div>It is nice without showing if condition bu=
t it becomes way more cryptic and complex. It will be very nice if ports in=
clude OPSYS, OSVERSION, etc:</div><br>OPTIONS_DEFINE=3D =C2=A0FOO BAR</div=
><div class=3D"gmail_quote">FOO_OSVERSION=3D > 1300000</div><div class=
=3D"gmail_quote">BAR_OSVERSION=3D > 1200000 && < 1300000 <br>=
</div><div class=3D"gmail_quote">FOO_EXTRA_PATCHES=3D =C2=A0${PATCHDIR}/ext=
ra-patch-foo<br>BAR_EXTRA_PATCHES_OFF=3D ${PATCHDIR}/extra-patch-bar.c<br><=
div><br></div><div>=C2=A0It's solved this way :)</div><div><br></div><d=
iv>Cheers,</div><div><br></div><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex">-- <br></blockquote></div><div dir=3D"ltr" class=3D"gmail_signature">=
<div dir=3D"ltr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>Fr=
eeBSD Committer (ports)</span></div></div></div>
--00000000000019805605e6e952cf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7U%2BoEPsaNhEdRwd-9wTm=OU9b1G6gqpT7a_e%2BWg=dYpLKA>