Date: Tue, 12 Jan 2010 02:03:50 -0600 From: Brooks Davis <brooks@FreeBSD.org> To: Brooks Davis <brooks@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r202143 - in head/sys: boot/forth compat/linux compat/svr4 i386/ibcs2 kern rpc security/audit sys Message-ID: <20100112080350.GA3193@lor.one-eyed-alien.net> In-Reply-To: <201001120749.o0C7nZ7j019654@svn.freebsd.org> References: <201001120749.o0C7nZ7j019654@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 12, 2010 at 07:49:35AM +0000, Brooks Davis wrote: > Author: brooks > Date: Tue Jan 12 07:49:34 2010 > New Revision: 202143 > URL: http://svn.freebsd.org/changeset/base/202143 >=20 > Log: > Replace the static NGROUPS=3DNGROUPS_MAX+1=3D1024 with a dynamic > kern.ngroups+1. kern.ngroups can range from NGROUPS_MAX=3D1023 to > INT_MAX-1. Given that the Windows group limit is 1024, this range > should be sufficient for most applications. With the commit, the only remaining delta to my projects/ngroups branch is: --- ../../head/sys/sys/param.h 2010-01-12 01:39:50.000000000 -0600 +++ ./sys/sys/param.h 2010-01-08 16:31:03.000000000 -0600 @@ -78,7 +78,6 @@ #define MAXLOGNAME 17 /* max login name length (i= ncl. NUL) */ #define MAXUPRC CHILD_MAX /* max simultaneous process= es */ #define NCARGS ARG_MAX /* max bytes for an exec fu= nction */ -#define NGROUPS (NGROUPS_MAX+1) /* max number groups */ #define NOFILE OPEN_MAX /* max open files per proce= ss */ #define NOGROUP 65535 /* marker for empty group s= et member */ #define MAXHOSTNAMELEN 256 /* max hostname size */ which would remove the NGROUPS definition entirely. Overall I think this would be a good thing as applications should not be written with NGROUPS or NGROUPS_MAX hard coded in, but I have not yet asked portmgr@ for a run to see how many ports this would break. I do not believe that NGROUPS is defined in any standard so removing it should only break non-portable code. -- Brooks --3V7upXqbjpZ4EhLz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFLTCzlXY6L6fI4GtQRAi5LAJ9cPeF18egS/iY129BK6lGpqptevwCgrQXm svo4yujw5cuUi4iOG3dxMdI= =OIEM -----END PGP SIGNATURE----- --3V7upXqbjpZ4EhLz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100112080350.GA3193>