Date: Wed, 05 Apr 2017 17:18:21 -0700 From: Cy Schubert <Cy.Schubert@komquats.com> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> Cc: Cy Schubert <Cy.Schubert@komquats.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316487 - head/etc Message-ID: <201704060018.v360IL31061110@slippy.cwsent.com> In-Reply-To: Message from =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> of "Thu, 06 Apr 2017 00:26:40 %2B0200." <861st64hjz.fsf@desk.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <861st64hjz.fsf@desk.des.no>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav? = w rites: > Cy Schubert <Cy.Schubert@komquats.com> writes: > > This patch caused some boot failures because the contents of rc_force were > > redefined from "yes" (for yes) and NULL (for no) to the words "yes" and > > "no". This in turn caused etc/rc.d/dhclient to assume force when $rc_force > > was not NULL (test -z failed). Interfaces with static IP addresses invoked > > rc.d/dhclient through devd. The attached patch should make all instances > > $rc_force consistent with your change. > > Yes, I just realized. I committed the wrong version of the patch. I > had a version in a different tree which added check_force > etc. functions. > > Could you please revert? I'd like to spend a little more time making > sure I get everything right. Sure, it's been reverted. People will need to remember to not run mergemaster or avoid updating rc.subr until the final version is committed or dhclient will *always* be started by devd regardless of rc.conf. Are you thinking of a more intrusive change like my first draft of the patch? ngie@ suggested that there be an UPDATING entry. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704060018.v360IL31061110>