Date: Thu, 07 Oct 2004 15:20:16 -0700 From: Nate Lawson <nate@root.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys pbioio.h src/sys/i386/isa pbio.csrc/sys/conf files.i386 src/sys/i386/conf NOTES Message-ID: <4165C120.7040005@root.org> In-Reply-To: <20041007175206.GA82275@ns1.xcllnt.net> References: <200410071621.i97GL3lu029620@repoman.freebsd.org> <20041007175206.GA82275@ns1.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar wrote: > On Thu, Oct 07, 2004 at 04:21:03PM +0000, Warner Losh wrote: > >>imp 2004-10-07 16:21:03 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/conf files.i386 >> sys/i386/conf NOTES >> Added files: >> sys/sys pbioio.h >> sys/i386/isa pbio.c >> Log: >> Port pbio to HEAD. > > > I appreciate your speed, but don't you think that pbioio.h is pretty > MD given that the driver only exists on i386. Wouldn't <machine/pbioio.h> > be a better place? Also, I think our policy for both RELENG_4 and -current is new inb/outb in new drivers. The bus_space stuff is pretty easy to use so this isn't too bad a requirement. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4165C120.7040005>