Date: Thu, 10 Oct 2019 18:39:32 +0300 From: Konstantin Belousov <kib@freebsd.org> To: Zhichao1.Li@dell.com Cc: freebsd-fs@freebsd.org, freebsd-drivers@freebsd.org, Shunchao.Hu@dell.com Subject: Re: a issue about getting a devfs node's fullpath Message-ID: <20191010153932.GO44691@kib.kiev.ua> In-Reply-To: <c6d34bd0b4114bee956b0af6d680a67f@KULX13MDC103.APAC.DELL.COM> References: <c6d34bd0b4114bee956b0af6d680a67f@KULX13MDC103.APAC.DELL.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 10, 2019 at 05:49:55AM +0000, Zhichao1.Li@dell.com wrote: > Dear freebsd developers > I know you're swamped, so I'll be brief. > I am trying to get a node's full under /dev by calling the function 'vn_fullpath', when dealing with things like '/dev/null' or '/dev/usb/1.0.1', it works well. > However when dealing a node under more than 2 sub directories (e.g. /dev/bus/usb/001/002) which I made by calling 'make_dev_s' , it goes a little bit different, I got a string "/dev/bus/usb/bus/usb/001/002" > And I found the function 'devfs_vptocnp' gets the string wrongly when dealing multi slashes path string, I have remark the code as followed and put some comments > would you please take a look, and tell me what the purpose this func pass the string that way? Try this. Not tested. diff --git a/sys/fs/devfs/devfs_vnops.c b/sys/fs/devfs/devfs_vnops.c index 3b80c68e309..f20b466d88b 100644 --- a/sys/fs/devfs/devfs_vnops.c +++ b/sys/fs/devfs/devfs_vnops.c @@ -284,38 +284,27 @@ devfs_vptocnp(struct vop_vptocnp_args *ap) if (error != 0) return (error); - i = *buflen; + if (vp->v_type != VCHR && vp->v_type != VDIR) { + error = ENOENT; + goto finished; + } + dd = vp->v_data; + if (vp->v_type == VDIR && dd == dmp->dm_rootdir) { + *dvp = vp; + vref(*dvp); + goto finished; + } - if (vp->v_type == VCHR) { - i -= strlen(dd->de_cdp->cdp_c.si_name); - if (i < 0) { - error = ENOMEM; - goto finished; - } - bcopy(dd->de_cdp->cdp_c.si_name, buf + i, - strlen(dd->de_cdp->cdp_c.si_name)); - de = dd->de_dir; - } else if (vp->v_type == VDIR) { - if (dd == dmp->dm_rootdir) { - *dvp = vp; - vref(*dvp); - goto finished; - } - i -= dd->de_dirent->d_namlen; - if (i < 0) { - error = ENOMEM; - goto finished; - } - bcopy(dd->de_dirent->d_name, buf + i, - dd->de_dirent->d_namlen); - de = dd; - } else { - error = ENOENT; + i = *buflen; + i -= dd->de_dirent->d_namlen; + if (i < 0) { + error = ENOMEM; goto finished; } + bcopy(dd->de_dirent->d_name, buf + i, dd->de_dirent->d_namlen); *buflen = i; - de = devfs_parent_dirent(de); + de = devfs_parent_dirent(dd); if (de == NULL) { error = ENOENT; goto finished;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191010153932.GO44691>