Date: Thu, 1 Jun 2017 20:06:05 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Marcel Moolenaar <marcel@FreeBSD.org>, Brooks Davis <brooks@FreeBSD.org>, svn-src-all@FreeBSD.org, "Simon J. Gerraty" <sjg@juniper.net>, src-committers <src-committers@FreeBSD.org>, svn-src-head@FreeBSD.org, Ngie Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Message-ID: <20170601200605.GA66626@FreeBSD.org> In-Reply-To: <EB38926C-C27C-4404-A1C4-69BC8525A00C@gmail.com> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> <84744.1496336318@kaos.jnpr.net> <20170601171642.GA601@FreeBSD.org> <EB38926C-C27C-4404-A1C4-69BC8525A00C@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 01, 2017 at 11:27:18AM -0700, Ngie Cooper (yaneurabeya) wrote: > ... > I vote for not checking in the SHAs. If something fails (as someone else > mentioned on the lists), it's really hard to debug why it failed. Like I've said, it's not "really" hard. Check out previous version and generate image with correct hash, there is no strong reason to commit the image other than minor usability improvement of not having to check out previous version. Then again, just my $.02 -- I'm not the one doing actual work here. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170601200605.GA66626>