Date: Tue, 18 Apr 2023 06:59:49 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Gordon Bergling <gbe@freebsd.org> Cc: Jessica Clarke <jrtc27@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: b12ccd0bb1b3 - main - stand: Remove double words in source code comments Message-ID: <ZD4/5ct2CICDmHX5@FreeBSD.org> In-Reply-To: <ZD4044dQFqKchPYO@lion.ttyv0.de> References: <202304180515.33I5FKdK006761@gitrepo.freebsd.org> <5B4D966A-896A-4C77-97CD-1594B9C79B42@freebsd.org> <ZD4044dQFqKchPYO@lion.ttyv0.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 18, 2023 at 08:12:51AM +0200, Gordon Bergling wrote: > On Tue, Apr 18, 2023 at 06:31:28AM +0100, Jessica Clarke wrote: > > On 18 Apr 2023, at 06:15, Gordon Bergling wrote: > [...] > > > --- a/stand/i386/boot0/Makefile > > > +++ b/stand/i386/boot0/Makefile > > > @@ -36,7 +36,7 @@ BOOT_BOOT0_FLAGS?= 0x8f > > > # 0xb6 (182d) corresponds to 10 seconds. > > > BOOT_BOOT0_TICKS?= 0xb6 > > > > > > -# The base address that we the boot0 code to to run it. Don't change this > > > +# The base address that we the boot0 code to run it. Don't change this > > > > This was correct and is now incorrect; read as "that we [load] the > > boot0 code to in order to run it". > > I just reverted the change. Sorry, not a native speaker on this side > and the sentence was a little hard to understand. This reminds me of the situation with commit 8ca67bf1273 which jrtc27@ pointed out was wrong, so I'd say again that comments like this should be rephrased: these consequent double words make it hard to understand and just begging for someone to try to "fix" it again in the future. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZD4/5ct2CICDmHX5>