Date: Fri, 13 Nov 2020 19:17:28 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r367648 - head/share/mk Message-ID: <647236BA-1263-4ABA-B03F-3789592EB649@freebsd.org> In-Reply-To: <202011131908.0ADJ8goO038839@repo.freebsd.org> References: <202011131908.0ADJ8goO038839@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 Nov 2020, at 19:08, Ed Maste <emaste@freebsd.org> wrote: > > Author: emaste > Date: Fri Nov 13 19:08:42 2020 > New Revision: 367648 > URL: https://svnweb.freebsd.org/changeset/base/367648 > > Log: > Fix `make makeman` after r367577 > > WITH_INIT_ALL_ZERO and WITH_INIT_ALL_PATTERN are mutually exclusive. > The .error when they were both set broke makeman so demote it to a > warning (and presumably the compiler will fail on an error later on). > > We could improve this to make one take precedence but this is sufficient > for now. You won't get an error. Currently bsd.{prog,lib}.mk and kern.mk check MK_INIT_ALL_ZERO then MK_INIT_ALL_PATTERN so the former takes precedence, but I suspect that if you were to pass the compiler flags for both the last flag would just override anything else, as is the case for most compiler flags. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?647236BA-1263-4ABA-B03F-3789592EB649>