Date: Sat, 6 Feb 2021 12:32:37 -0600 From: Kyle Evans <kevans@freebsd.org> Cc: Eric Joyner <erj@freebsd.org>, Krzysztof Galazka <krzysztof.galazka@intel.com>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7d4dceec1030 - main - ixl(4): Fix VLAN HW filtering Message-ID: <CACNAnaE2vVZ=jz3HDQjuByDFQgZAef9raPgqP_OPnyKCTZ=u%2BQ@mail.gmail.com> In-Reply-To: <CACNAnaGD1Uutv0VZLG=9sHhXBckus=1YAefs6oMpkmHHxGS2DQ@mail.gmail.com> References: <202102042333.114NXowE086993@gitrepo.freebsd.org> <CACNAnaGD1Uutv0VZLG=9sHhXBckus=1YAefs6oMpkmHHxGS2DQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Feb 6, 2021 at 12:30 PM Kyle Evans <kevans@freebsd.org> wrote: > > On Thu, Feb 4, 2021 at 5:34 PM Eric Joyner <erj@freebsd.org> wrote: > > > > The branch main has been updated by erj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=7d4dceec103039e2b2fa90793ceeb71a8d6684aa > > > > commit 7d4dceec103039e2b2fa90793ceeb71a8d6684aa > > Author: Krzysztof Galazka <krzysztof.galazka@intel.com> > > AuthorDate: 2021-02-03 23:22:55 +0000 > > Commit: Eric Joyner <erj@FreeBSD.org> > > CommitDate: 2021-02-04 23:33:42 +0000 > > > > ixl(4): Fix VLAN HW filtering > > > > X700 family of controllers has limited number of available VLAN > > HW filters. Driver did not handle properly a case when user > > assigned more VLANs to the interface which had all filters > > already in use. Fix that by disabling HW filtering when > > it is impossible to create filters for all requested VLANs. > > Keep track of registered VLANs using bitstring to be able > > to re-enable HW filtering when number of requested VLANs > > drops below the limit. > > > > Also switch all allocations to use M_IXL malloc type > > to ease detecting memory leaks in the driver. > > > > Hi, > > This adds a dependency on `device ixl` for `device iavf` since M_IXL > is defined in ixl_pf_main.c, but I think that particular part should > be partially reverted anyways. There's an M_IAVF already that's more > appropriate for i40e_osdep.c -- proposed patch here: > https://people.freebsd.org/~kevans/0001-ixl-switch-i40e_osdep.c-allocations-to-M_IAVF.patch > Ah crud, nope. I missed that i40e_osdep is pulled in for ixl as well. :-(
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaE2vVZ=jz3HDQjuByDFQgZAef9raPgqP_OPnyKCTZ=u%2BQ>