Date: Mon, 11 Nov 1996 20:34:06 -0800 (PST) From: asami@freebsd.org (Satoshi Asami) To: ache@freefall.freebsd.org Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-ports@freefall.freebsd.org Subject: Re: cvs commit: ports/news/tin Makefile ports/news/tin/files md5 ports/news/tin/patches patch-aa Message-ID: <199611120434.UAA09559@silvia.HIP.Berkeley.EDU> In-Reply-To: <199611112309.PAA18310@freefall.freebsd.org> (ache@freefall.freebsd.org)
next in thread | previous in thread | raw e-mail | index | archive | help
* Modified: news/tin Makefile
Thanks. By the way, these lines:
===
DISTNAME= tin1.3-unoff-BETA-961109
PKGNAME= tin-1.3.${DISTNAME:S/tin1.3-unoff-BETA-//}
===
Do you mind if I replace the second line with a regular variable
assignment to PKGNAME? This is causing me a lot of headaches when you
do an upgrade, because I need to delete the old package and its name
is not available anywhere in the above for cut & paste. ;)
In general, I think munging with :S and stuff for simple variables
like PKGNAME is not a good idea. The only times I use this is when
the two variables are very far apart in the Makefile (and so the
second is more likely to be forgotten when I do an upgrade) or when
there are many things to replace.
Satoshi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199611120434.UAA09559>