Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Mar 2019 14:55:44 +0000
From:      bugzilla-noreply@freebsd.org
To:        testing@freebsd.org
Subject:   [Bug 236842] check if_tap.ko for sys/netmap/ctrl-api-test test
Message-ID:  <bug-236842-32464-6BPOSshpUr@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-236842-32464@https.bugs.freebsd.org/bugzilla/>
References:  <bug-236842-32464@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236842

--- Comment #5 from Alan Somers <asomers@FreeBSD.org> ---
I can see how that section of the committer's guide is confusing.  Let me
clarify:

A non-mentored src committer like can provide an "Approved by" or a "Review=
ed
by".  A mentored src committer like ngie can only provide a "Reviewed by".=
=20
"Reviewed by" is purely informational, but "Approved by" is needed for comm=
its
to certain areas, or for any commits by a mentored committer.

And yes I approve this commit.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-236842-32464-6BPOSshpUr>