Date: Mon, 14 Apr 2014 09:42:36 +0200 From: Christian Brueffer <brueffer@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r264421 - head/sys/netpfil/ipfw Message-ID: <534B916C.6030700@FreeBSD.org> In-Reply-To: <20140414170654.Y5260@besplex.bde.org> References: <201404132113.s3DLDXRI044236@svn.freebsd.org> <20140414170654.Y5260@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 4/14/14 9:35 AM, Bruce Evans wrote: > On Sun, 13 Apr 2014, Christian Brueffer wrote: > >> Log: >> Free resources and error cases; re-indent a curly brace while here. > > The patch begins with a misindented block in old code. I thought at > first the whole file was misindented with 4-column indents and the > patch is backwards, as in a recent commit to ata, but here it is mainly > the is7 code that is misindented, while in ata the indentation was > already mangled throughout the file (ata started in sosNF with 4-column > indents and other style bugs, but now has a mangled mess of sosNF and > KNF indents and other style bugs). > Yup, the whole file is a mess. I tried to adhere to the local style of the respective code blocks for now. Chris [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQJ8BAEBCgBmBQJTS5FtXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ5QzhCQjQ5MDgzNDUwNjkyOUM5Mjg2NDE3 OEM4MzY5ODQ3RTE2NDg3AAoJEHjINphH4WSHCWgP/25J1o9Pnv+/Fr2Va/GD7e9M KDTTao6tm92i1ITuxBUULz9QI33391tR5YqqgOoyZ+QPqWRZze5jhEDbjMiIYLYU 97KBfrS3/iLUnwc4bqu3f8avvoOTXVw8twx0ki0xZpB+EGoV7pHC/mCWGSt3TPMd avUcRQ8+0V6Ik/4tpIKugXN58Mu1trstSxMMJGh5QG/zHNj6S3we/uwYX6xjqW4d TgeT7uYtbmxVxO+I7StiRhY04KM2CZ207vt6UzsBJvYizhfWsDr66P89bNKxNZe4 cr8PnXLleC6AndDhmQ1M6fE5NJfobMy5kEJ9r/Gdg004b88Wlil0nzYf6WcIV0jn leQAjRvlILKXpLAPUkMV7u3FgmWxqHMj3dupVDP19LycL/Kd/Zllkzy4SlfTwH3m SzGgEri85kPq9zdgMJo1lA8BzPaQmcTob0cq3KVxXOvKpI5n0o7C88UToOZc0Hxy GvGGrGwfB3M1gsCFNtxm5BjuPM6Oh6zp9b5ng18UTvLFqaj8wbY/ufuLoBFoCH6f C0Zs0pPB5NAfBMMMbVfN+Ym+HwctcwWqee3ohrT1rbDLhozYiftW1UO0K4DsJTad nyj9kTzP+hg6wbpbBr+ce5aNQy3Xha6NiXYNm0ZO5hr0T3qOjOn1GqrmgWBuvSqw cfSyG2SPZP7wy/e6JiyC =tePr -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?534B916C.6030700>