Date: Sun, 3 Mar 2024 09:56:38 +0100
From: Mathieu Arnold <mat@freebsd.org>
To: Gleb Popov <arrowd@freebsd.org>
Cc: Thomas Zander <riggs@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject: Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG
Message-ID: <5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay@qbtuvdsmy7fk>
In-Reply-To: <CALH631k%2BK%2Bf2Tpmk9HGX%2BWydcB8xe-xquRSKYitUzXGc7eO4bQ@mail.gmail.com>
References: <202403021836.422Ia4o2021754@gitrepo.freebsd.org> <CALH631k%2BK%2Bf2Tpmk9HGX%2BWydcB8xe-xquRSKYitUzXGc7eO4bQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--wvrmk75uij2lfiqu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 03, 2024 at 09:55:12AM +0300, Gleb Popov wrote: > On Sat, Mar 2, 2024 at 9:36=E2=80=AFPM Thomas Zander <riggs@freebsd.org> = wrote: > > > > The branch main has been updated by riggs: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Da995b8b0ab54b250167531= dafc38fc1342558446 > > > > commit a995b8b0ab54b250167531dafc38fc1342558446 > > Author: Thomas Zander <riggs@FreeBSD.org> > > AuthorDate: 2024-03-02 10:26:32 +0000 > > Commit: Thomas Zander <riggs@FreeBSD.org> > > CommitDate: 2024-03-02 18:36:02 +0000 > > > > multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG > > > > Details: > > This is a revert of c1e0f931e3ddecb86d83ffc14cb8b05a38922cdd plus > > removing the DEBUG OPTION from mencoder as well, following the tren= d to > > phase out DEBUG as an option. >=20 > I wouldn't say that there is a trend to remove the DEBUG option, but > this specific change you made does make sense. There is no trend, it's a rule, debug must be handled with WITH_DEBUG knob, and not via an option. If there is an option that enable some sort of debugging or verbose thing but that is not supposed to add debugging symbols, then it should not be called DEBUG. --=20 Mathieu Arnold --wvrmk75uij2lfiqu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmXkO0VfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb60wwv+POHMjULptpwwzpbynVeKKaNDlikR5eDZ1jNxEFjqPVsJ9L6SM3PMF24g MqL9zqLYggfgi16BQ6CgBw/mj0aJXTwSu412E2V7f1L4nR0Dv6URxwYK/DSGcEWv sNpqHaTYKhL2RBY8TF63G4K7N9heN9242oSoT1J52RsLhv6x1dmGTwjiNgBKwUju HzDhKsvOsFshh+3npytK8NNyFzSoO8d1qB1JdAUOgK4B9c6cwNecchVq+uPmt8Ee PlG12RyOBEWiEV/Id6MFpbsmCvAbYNlTDQ7IYPbyBrP/UvgbsFrToyZBSBjnh+nF R85sXTlUPaezozzl7NYCjh2hxfpeefao1VBigW+AUUl9hkQIdg2adg3OJ1UA0I1h mWD2JSWugzApYJKWllcwjRZrAwah87Klb0u53UfATaVfL/DYJNRmGrQQ5Rw5QxqN nMdDUlPvMf9ne0atIayEAVOh/2vA6AkRhJyY59E5nw6z+XouzTHTAsSJ9k8aF8DR TpM0sqP/ =2vnH -----END PGP SIGNATURE----- --wvrmk75uij2lfiqu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5l6vknhs4q4ljz5fe52ksdofxsnfaautnuetnqeb5cbj5c2uay>