Date: Mon, 07 Mar 2022 17:29:42 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262038] fts(3): Check for readdir(3) errors Message-ID: <bug-262038-227-zCoHorVrM8@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-262038-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262038 Mark Johnston <markj@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open CC| |markj@FreeBSD.org --- Comment #1 from Mark Johnston <markj@FreeBSD.org> --- This looks ok to me overall. A couple of comments: - We have fts-compat.c and fts-compat11.c which appear to have the same bug. - There are some style bugs: missing parens around the return value in fts_safe_readdir(); extra indentation for line 882 should be by four spaces, not a tab. I also think it'd be better to avoid checking errno directly, and instead modify fts_safe_readdir() to take a pointer to a readdir_errno integer variable, setting that if an error occurs. Maybe it's not worth it to diverge much from other copies of this code, though. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-262038-227-zCoHorVrM8>