Date: Mon, 25 May 2020 22:04:37 +0000 From: "melifaro (Alexander V. Chernikov)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-net@freebsd.org Subject: [Differential] D24989: netinet: Generate a random RSS key on boot. Message-ID: <b3dc4a973c8fada15a2f1b7f0dd57c0b@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-yukac7sf5rncf2mc6vjo-req@reviews.freebsd.org> References: <differential-rev-PHID-DREV-yukac7sf5rncf2mc6vjo-req@reviews.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
melifaro added inline comments. INLINE COMMENTS > rss_config.c:251 > */ > + arc4random_buf(&rss_key, RSS_KEYSIZE); > } Are we sure that there is enough entropy available at the moment of calling it? REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVISION DETAIL https://reviews.freebsd.org/D24989 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_neelc.org Cc: debdrup, rwatson, imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b3dc4a973c8fada15a2f1b7f0dd57c0b>