Date: Wed, 28 Nov 2001 11:59:23 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: obrien@FreeBSD.org Cc: des@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Meaningless commit messages [was: cvs commit: ports/www/linux-opera Makefile] Message-ID: <3C04B57B.ACEB6705@FreeBSD.org> References: <200111271749.fARHnG165639@freefall.freebsd.org> <200111272030.WAA04863@ipcard.iptcom.net> <20011127185144.A18875@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien wrote: > > On Tue, Nov 27, 2001 at 10:30:14PM +0200, Maxim Sobolev wrote: > > On Tue, 27 Nov 2001 09:49:16 -0800 (PST), Dag-Erling Smorgrav wrote: > > > des 2001/11/27 09:49:16 PST > > > > > > Modified files: > > > www/linux-opera Makefile > > > Log: > > > Pander to the backseat drivers. > > > > Could you please use more meaningful commit messages? For > > example it is absolutely impossible to guess what this > > commit is all about without looking at the diff. > > Without even looking at the diffs, it is obviously some minor style change > (or nit fixed) due to feedback from a previous commit. BZZZTT, WRONG! After looking at the diff it is apparent that actually this change corrected version number for the package to be compliant with our conventions. Previous version number contained `-', which isn't allowed. This isn't a `minor style change' because such change could potentially affect all users who use some form of autoupdate tools. I suspect that in this particular case PORTEPOCH should be bumped as well, because package name was changed from `linux-opera-6.0-20011122.1' to `linux-opera-6.0.20011122.1', so that version number has decreased from 20011122.1 to 6.0.20011122.1. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C04B57B.ACEB6705>