Date: Wed, 14 Feb 2018 23:24:28 -0700 From: Warner Losh <imp@bsdimp.com> To: Eitan Adler <eadler@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329296 - head/sbin/devd Message-ID: <CANCZdfrSc4U9UmJ36aexncBP7UmqHVYsmVE-6%2BVW338uHqBZ-A@mail.gmail.com> In-Reply-To: <CAF6rxgmyE93-kcadMSjz8YVA26uWG1wBH7DQEoJmdfJmVw0oUg@mail.gmail.com> References: <201802150322.w1F3Mrie018786@repo.freebsd.org> <CANCZdfrEPUJoQKMYKHDZj8cW5Na_6ODZZVzL9nCO2A1p7nTSTg@mail.gmail.com> <CANCZdfqD3hK9ExKveB-Y_TY4yRW8JEaUc13r8_u4FPXb295W8Q@mail.gmail.com> <CAF6rxgmyE93-kcadMSjz8YVA26uWG1wBH7DQEoJmdfJmVw0oUg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 14, 2018 at 8:51 PM, Eitan Adler <eadler@freebsd.org> wrote: > On 14 February 2018 at 19:48, Warner Losh <imp@bsdimp.com> wrote: > > > > > > On Wed, Feb 14, 2018 at 8:39 PM, Warner Losh <imp@bsdimp.com> wrote: > >> > >> > >> > >> On Feb 14, 2018 8:23 PM, "Eitan Adler" <eadler@freebsd.org> wrote: > >> > >> Author: eadler > >> Date: Thu Feb 15 03:22:53 2018 > >> New Revision: 329296 > >> URL: https://svnweb.freebsd.org/changeset/base/329296 > >> > >> Log: > >> devd: don't pass &fds in useless parameters to select(2) > >> > >> select(2) should be declared as restrict. In addition the only fd in > >> the fdset is open O_RDONLY, and it's not a socket that can provide OOB > >> notifications, > >> > >> Reviewed by: ian, imp, vangyzen > >> > >> > >> Don't put my name on this. I specifically and clearly objected to the > >> change anf tld yoy not to do it. > > > > > > Stupid phone... > > > > I specifically objected to this change. I said not to make it because it > > wasn't necessary. You did it any way. Don't put "reviewed by" for that. > Put > > "objected to but I did it anyway by: imp" > > hrm.. rereading the thread I think I missed your original email. Only > comment I saw was "poll is a better interface". Sorry for mis-stating > your opinion. > Yea. It was more of a "don't change it, since it's fine now" and then the "poll" comment was "better to just change to a better interface." > FTR I'd like to fix the declaration of select(2) anyways. That's unlikely to end well... I wish you luck... The pattern I used in devd for select was nearly universal a decade ago... Maybe things have changed... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrSc4U9UmJ36aexncBP7UmqHVYsmVE-6%2BVW338uHqBZ-A>