Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 02 Jul 2001 23:48:16 -0400 (EDT)
From:      Mike Heffner <mheffner@novacoxmail.com>
To:        Mike Heffner <mheffner@vt.edu>
Cc:        audit@FreeBSD.org, Mike Barcroft <mike@q9media.com>
Subject:   RE: src/bin/chio patch
Message-ID:  <XFMail.20010702234816.mheffner@novacoxmail.com>
In-Reply-To: <XFMail.20010702232229.mheffner@novacoxmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format
--_=XFMail.1.5.0.FreeBSD:20010702234816:393=_
Content-Type: text/plain; charset=us-ascii


On 03-Jul-2001 Mike Heffner wrote:
| 
| On 29-Jun-2001 Mike Barcroft wrote:
|| I would appreciate it if someone would review and commit the patch at
|| the end of this message.  Also available at:
|| http://testbed.q9media.net/freebsd/chio.20010628.patch
|| 
| 
| Done, thanks!

Unfortunately I had to revert the Makefile WARNS addition because I forgot to
test on alpha first ;(  I'll try and look at cleaning up the alpha
warnings tomorrow. Below is the compiler warnings from beast in case anyone
wants to take a stab at it:

cc -W -Wall -ansi -pedantic -Wbad-function-cast -Wcast-align  -Wcast-qual
-Wchar-subscr
ipts -Wconversion -Winline  -Wmissing-prototypes -Wnested-externs
-Wpointer-arith  -Wre
dundant-decls -Wshadow -Wstrict-prototypes -Wwrite-strings    -c chio.c
chio.c:124: warning: function declaration isn't a prototype
chio.c: In function `do_status':
chio.c:692: warning: passing arg 1 of `calloc' with different width due to
prototype
chio.c:711: warning: passing arg 1 of `bits_to_string' as signed due to
prototype
chio.c: In function `do_voltag':
chio.c:849: warning: pointer targets in passing arg 1 of `strncpy' differ in
signedness
chio.c: In function `do_return':
chio.c:1009: warning: passing arg 1 of `get_element_status' with different
width due to
 prototype
chio.c:1009: warning: passing arg 2 of `get_element_status' with different
width due to
 prototype
chio.c: In function `get_element_status':
chio.c:1047: warning: promoted argument `type' doesn't match prototype
chio.c:69: warning: prototype declaration
chio.c:1047: warning: promoted argument `element' doesn't match prototype
chio.c:69: warning: prototype declaration
chio.c:1052: warning: passing arg 1 of `calloc' with different width due to
prototype
chio.c: In function `find_element':
chio.c:1105: warning: passing arg 1 of `calloc' with different width due to
prototype
chio.c:1188: warning: pointer targets in passing arg 2 of `strcasecmp' differ
in signed
ness


Mike

-- 
  Mike Heffner         <mheffner@[acm.]vt.edu>
  Fredericksburg, VA       <mikeh@FreeBSD.org>


--_=XFMail.1.5.0.FreeBSD:20010702234816:393=_
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE7QUCAFokZQs3sv5kRAl60AJ9Jo2xegNnPKlLBpgZcq66DbzVkQQCeLgFO
kdjNU7+MQLeVN+POvxAIa6E=
=WvN3
-----END PGP SIGNATURE-----

--_=XFMail.1.5.0.FreeBSD:20010702234816:393=_--
End of MIME message

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20010702234816.mheffner>