Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Nov 2015 11:01:52 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Gerald Pfeifer <gerald@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r402352 - head/lang/gcc
Message-ID:  <20151124110152.GA78748@FreeBSD.org>
In-Reply-To: <201511241019.tAOAJMTF049917@repo.freebsd.org>
References:  <201511241019.tAOAJMTF049917@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 24, 2015 at 10:19:22AM +0000, Gerald Pfeifer wrote:
> Author: gerald
> URL: https://svnweb.freebsd.org/changeset/ports/402352
> 
> [...]
> @@ -168,5 +168,10 @@ post-stage:
>  	fi
>  .endfor
>  	cd ${WRKDIR} ; ${SED} -i -e "/PLIST.lib/ r PLIST.lib" ${TMPPLIST}
> +	# This is the canonical GCC port, so add key commands without
> +	# version numbers as part of their names.

Comment is badly indented (will be executed as part of the target recipe).

> +	for c in gfortran g++ gcc; do \
> +	    ${LN} -s ${PREFIX}/bin/"$$c"${SUFFIX} ${STAGEDIR}${PREFIX}/bin/$$c ; \
> +	done

Symlinks are badly created (will be broken if e.g. $prefix mounted under
non-/ via NFS), better (untested) approach would be:

.for f in gfortran g++ gcc
	${LN} -sf ${f}${SUFFIX} ${STAGEDIR}${PREFIX}/bin/${f}
.endfor

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151124110152.GA78748>