Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Mar 1995 23:53:46 -0800
From:      "Justin T. Gibbs" <gibbs@estienne.CS.Berkeley.EDU>
To:        Gennady Sorokopud <gena@netvision.net.il>
Cc:        "Jordan K. Hubbard" <jkh@freebsd.org>, CVS-commiters@time.cdrom.com, cvs-sys@time.cdrom.com
Subject:   Re: cvs commit: src/sys/i386/isa if_ep.c if_epreg.h 
Message-ID:  <199503310753.XAA01697@estienne.cs.berkeley.edu>
In-Reply-To: Your message of "Fri, 31 Mar 1995 10:44:06 %2B0300." <199503310744.KAA09715@Burka.NetVision.net.il> 

next in thread | previous in thread | raw e-mail | index | archive | help
>>>jkh         95/03/30 22:41:39
>>>
>>>  Modified:    sys/i386/isa if_ep.c if_epreg.h
>>>  Log:
>>>  *  Promiscuous mode added and interrupt logic slightly changed
>>>  *  to reduce the number of adapter failures. Transceiver select
>>>  *  logic changed to use value from EEPROM. Autoconfiguration
>>>  *  features added.
>>>  Submitted by:	"Serge A. Babkin" <babkin@hq.icb.chel.su>
>>
>>Did you test these on a 3c509?  I was planning on testing these patches 
>>tomorrow (my office machine has a 3C509) and then committing.  When 
>>david commited the last batch of patches from Serge, it was only after
>>I tested them out first.
>>--
>>Justin T. Gibbs
>>==============================================
>>TCS Instructional Group - Programmer/Analyst 1
>>  Cory | Po | Danube | Volga | Parker | Torus
>>==============================================
>I've tested it . (I have 2 FreeBSD-current machines with 3c509 cards here ).
>Works fine , even the promiscous mode! I finally can get rid of
>old NE1000 that i used as spying agent :))
>

Oh, I'm not saying that they won't work, but in most cases, if there is someone
on the commit list that has the specific hardware to test a patch, it will be 
tested before being comitted.  The reason that only certain people have
commit priveledges is so that patches can be reviewed before being incorperated
into the tree.  My question to Jordan was about how good a review he gave
the code before putting it in the tree.

>
>O                      Gennady Sorokopud                             O

--
Justin T. Gibbs
==============================================
TCS Instructional Group - Programmer/Analyst 1
  Cory | Po | Danube | Volga | Parker | Torus
==============================================



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199503310753.XAA01697>