Date: Tue, 30 Nov 2004 21:23:16 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/mount mntopts.h mount.8 mount.c src/sbin/mount_std mount_std.8 Message-ID: <20041130192316.GB3845@ip.net.ua> In-Reply-To: <52202.1101838031@critter.freebsd.dk> References: <20041130090553.GA691@ip.net.ua> <52202.1101838031@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Nov 30, 2004 at 07:07:11PM +0100, Poul-Henning Kamp wrote: > In message <20041130090553.GA691@ip.net.ua>, Ruslan Ermilov writes: > > >> FYI, this commit seems to have broken my line in fstab which has worked f > >or > >> a long time: > >> > >> md /tmp mfs rw,-s16m,noatime,nosuid,nodev 2 0 > >> > >> Is it useful for the nodev option to cause a hard failure here? Note, I'm > >> not arguing against either change, just pointing out a side effect. > >> > >There's no longer a "nodev" option, please ask Poul-Henning for details. ;) > > The reason I did not remove MNT_NODEV but only #defined it to zero was > to make it silently ignored. > To make it silently ignored, you should have left it with its old value. Most operations with MNT_* constants are "bitwise AND", and so zero was not a good choice. Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBrMikqRfpzJluFF4RAvKfAJ99HKm5JF4MBxwc49R/RBk+3JSH6wCaAx5A 4ytEEnE2qzEMVnAedRMnn3g= =F6G0 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041130192316.GB3845>