Date: Tue, 8 Oct 2024 18:16:13 -0400 From: Ka Ho Ng <khng300@gmail.com> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Dmitry Morozovsky <marck@rinet.ru>, Shawn Webb <shawn.webb@hardenedbsd.org>, Ka Ho Ng <khng@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 50c64df2a173 - main - Revert "libkldelf: add a private library for kernel/kld-related ELF parsing" Message-ID: <CANnchUb87Fk2mQzeZPaG=DhcPo7T7QRkkRBc27H4_2VA6jDxog@mail.gmail.com> In-Reply-To: <20241008201627.4EE5719D@slippy.cwsent.com> References: <202410081940.498JeV5t035958@gitrepo.freebsd.org> <f6isambl5gos4wri3jorwfzfzallx57no3njmgnoff5of2eq26@nn5wqb5s6xsk> <alpine.BSF.2.00.2410082251130.15838@woozle.rinet.ru> <20241008201627.4EE5719D@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Oct 8, 2024 at 4:16 PM Cy Schubert <Cy.Schubert@cschubert.com> wrote: > In message <alpine.BSF.2.00.2410082251130.15838@woozle.rinet.ru>, Dmitry > Morozo > vsky writes: > > On Tue, 8 Oct 2024, Shawn Webb wrote: > > > > > On Tue, Oct 08, 2024 at 07:40:31PM UTC, Ka Ho Ng wrote: > > > > The branch main has been updated by khng: > > > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=50c64df2a1739dca84c0e3bc795b > > 70e5991b7010 > > > > > > > > commit 50c64df2a1739dca84c0e3bc795b70e5991b7010 > > > > Author: Ka Ho Ng <khng@FreeBSD.org> > > > > AuthorDate: 2024-10-08 19:40:20 +0000 > > > > Commit: Ka Ho Ng <khng@FreeBSD.org> > > > > CommitDate: 2024-10-08 19:40:20 +0000 > > > > > > > > Revert "libkldelf: add a private library for kernel/kld-related > ELF p > > arsing" > > > > > > > > This reverts commit 0a2cfd653e86ac41c4e6e32a449d133c0ee6d677. > > > > > > Could you please explain why? > > > > bapt@: Since this set of commits, incremental building of packages > fail! > > Hmm. I didn't experience this in my poudriere here. > > > -- > Cheers, > Cy Schubert <Cy.Schubert@cschubert.com> > FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org > NTP: <cy@nwtime.org> Web: https://nwtime.org > > e^(i*pi)+1=0 > > > It affects pkgbase users mainly, and the reason is rather due to the linkage issue between the separated privatelib and kldxref resulting in empty LINKER_SETs in the privatelib. I will recommit this once it's fixed. Ka Ho [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><div dir="ltr"></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 8, 2024 at 4:16 PM Cy Schubert <<a href="mailto:Cy.Schubert@cschubert.com">Cy.Schubert@cschubert.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">In message <<a href="mailto:alpine.BSF.2.00.2410082251130.15838@woozle.rinet.ru" target="_blank">alpine.BSF.2.00.2410082251130.15838@woozle.rinet.ru</a>>, Dmitry <br> Morozo<br> vsky writes:<br> > On Tue, 8 Oct 2024, Shawn Webb wrote:<br> ><br> > > On Tue, Oct 08, 2024 at 07:40:31PM UTC, Ka Ho Ng wrote:<br> > > > The branch main has been updated by khng:<br> > > > <br> > > > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=50c64df2a1739dca84c0e3bc795b" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=50c64df2a1739dca84c0e3bc795b</a><br>; > 70e5991b7010<br> > > > <br> > > > commit 50c64df2a1739dca84c0e3bc795b70e5991b7010<br> > > > Author: Ka Ho Ng <khng@FreeBSD.org><br> > > > AuthorDate: 2024-10-08 19:40:20 +0000<br> > > > Commit: Ka Ho Ng <khng@FreeBSD.org><br> > > > CommitDate: 2024-10-08 19:40:20 +0000<br> > > > <br> > > > Revert "libkldelf: add a private library for kernel/kld-related ELF p<br> > arsing"<br> > > > <br> > > > This reverts commit 0a2cfd653e86ac41c4e6e32a449d133c0ee6d677.<br> > > <br> > > Could you please explain why?<br> ><br> > bapt@: Since this set of commits, incremental building of packages fail!<br> <br> Hmm. I didn't experience this in my poudriere here.<br> <br> <br> -- <br> Cheers,<br> Cy Schubert <<a href="mailto:Cy.Schubert@cschubert.com" target="_blank">Cy.Schubert@cschubert.com</a>><br> FreeBSD UNIX: <cy@FreeBSD.org> Web: <a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a><br>; NTP: <<a href="mailto:cy@nwtime.org" target="_blank">cy@nwtime.org</a>> Web: <a href="https://nwtime.org" rel="noreferrer" target="_blank">https://nwtime.org</a><br>; <br> e^(i*pi)+1=0<br> <br> <br></blockquote><div>It affects pkgbase users mainly, and the reason is rather due to the linkage issue between the separated privatelib and kldxref resulting in empty LINKER_SETs in the privatelib. I will recommit this once it's fixed. </div><div><br></div><div>Ka Ho</div></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANnchUb87Fk2mQzeZPaG=DhcPo7T7QRkkRBc27H4_2VA6jDxog>