Date: Tue, 4 Apr 2023 12:48:46 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: "Pokala, Ravi" <rpokala@panasas.com> Cc: Martin Matuska <mm@FreeBSD.org>, Rick Macklem <rick.macklem@gmail.com>, Mateusz Guzik <mjguzik@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: 8ee579abe09e - main - zfs: fall back if block_cloning feature is disabled Message-ID: <20230404124846.576d26fd@slippy> In-Reply-To: <20230404123054.6cf5fb6b@slippy> References: <202304041145.334Bjx6l035872@gitrepo.freebsd.org> <20230404141717.B976D31C@slippy.cwsent.com> <CAGudoHEvGDUQkYe8LwUXgTZZa%2B6DAFXVtspCX-Mn2egDO2oc_w@mail.gmail.com> <CAM5tNy6sPx4xE%2BcAeeC_RQG_tba_K6Yh-Cni0%2B-WxJ5SXCuO9A@mail.gmail.com> <98c71e6f-5b48-79f3-e7b0-95d674949624@FreeBSD.org> <20230404091844.639cb1c1@slippy> <5B7F71CC-5BE6-4938-A29E-E10B01A4E4ED@panasas.com> <20230404123054.6cf5fb6b@slippy>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Apr 2023 12:30:54 -0700 Cy Schubert <Cy.Schubert@cschubert.com> wrote: > On Tue, 4 Apr 2023 17:54:28 +0000 > "Pokala, Ravi" <rpokala@panasas.com> wrote: > > > Cy, > > > > The patch adds 'bool done_outvp', unconditionally sets it to 'true', and then later has a check for 'if (!done_outvp)'. Since there is no intervening place where 'done_outvp' could be set to 'false', that check will never succeed and that branch is unreachable. > > It's set to false at line 6454, in the loop locking vnodes. > > > > > Or am I mis-reading something? > > Maybe Rick can explain but all we're doing is ensuring that the first > part of the loop is executed only first time through. We could invert it > and save setting it to false every loop. No. Looking at it more closely, I was wrong. What Rick is doing is probably the best approach. > > > > > Thanks, > > > > Ravi (rpokala@) > > > I'll try to put together a review tonight. Having said that, I don't want to take the credit for this "final" fix. We have Martin and Rick to thank for doing the heavy lifting. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e^(i*pi)+1=0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230404124846.576d26fd>