Date: Fri, 8 Jan 2010 11:45:30 -0500 From: David Schultz <das@FreeBSD.ORG> To: Jaakko Heinonen <jh@FreeBSD.ORG> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG Subject: Re: svn commit: r200633 - head/usr.bin/uniq Message-ID: <20100108164530.GA62775@zim.MIT.EDU> In-Reply-To: <200912171703.nBHH3mEn041893@svn.freebsd.org> References: <200912171703.nBHH3mEn041893@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 17, 2009, Jaakko Heinonen wrote: > Sync getline() with comm(1): > > - Prevent overflowing of the buffer length variable in getline() by > limiting its maximum value. > - Exit if reallocf(3) fails in getline(). Failure was silently > considered as end-of-file. We should consider using getline(3) from libc, rather than hand-rolled versions of almost the same thing that are copy-pasted in multiple places. The only catch is I need to check in the wide character version of getline() I've had sitting in my tree for months. I'll try to get on that this weekend.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100108164530.GA62775>