Date: Sun, 11 Apr 2021 22:55:33 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 254986] w: proc_compare() call is no-op since 1997 Message-ID: <bug-254986-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254986 Bug ID: 254986 Summary: w: proc_compare() call is no-op since 1997 Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: yuripv@FreeBSD.org https://cgit.freebsd.org/src/commit/?id=1bb32253c5cda8ca149df65ef4adae4d7165357a turned proc_compare() into no-op by only calling it with one of the arguments being NULL, so that the other argument always "wins" and is considered the "most interesting" process, and we never call proc_compare() again because of the NULL check. I had review D25398 (abandoned) for this, but I'm simply not sure if removing proc_compare() is correct way to handle this instead of fixing it properly, so I'm filing PR in case anyone else wants to take care of it. -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-254986-227>