Date: Mon, 19 Apr 2021 15:58:33 -0600 From: Warner Losh <imp@bsdimp.com> To: "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net> Cc: Baptiste Daroussin <bapt@nours.eu>, Ed Maste <emaste@freebsd.org>, current <current@freebsd.org> Subject: Re: sys/sys/param.h: 'main' instead of 'Master'? Message-ID: <CANCZdfoAr9YLiPObfKaYVrprat%2BZotzwqhy1kfideXoJouA8OA@mail.gmail.com> In-Reply-To: <202104191312.13JDCJO8066436@gndrsh.dnsmgr.net> References: <20210419072723.jd5jyys4go3rfwkv@aniel.nours.eu> <202104191312.13JDCJO8066436@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 19, 2021 at 7:12 AM Rodney W. Grimes < freebsd-rwg@gndrsh.dnsmgr.net> wrote: > > On Sun, Apr 18, 2021 at 07:07:44PM -0400, Ed Maste wrote: > > > On Fri, 16 Apr 2021 at 16:22, Warner Losh <imp@bsdimp.com> wrote: > > > > > > > > > > As well as "Origin". > > > > > > > > > > (Single) Source of Truth, maybe? > > > > > > > > s/Master, p/P/ also makes sense. > > > > > > IMO instead of lightly rewording the existing comment we could just > > > remove it, it doesn't really add any clarity. > > > > > > Instead we ought to add an introductory sentence or two to the block > > > comment above, explaining what __FreeBSD_version actually is. > > > > fully agreed here! I had to explained many time what __FreeBSD_version > actually > > was. A clear comment would be great ;) > > Yes please! Well, we explain the scheme w/o explaining when / why you'd want to bump it. https://reviews.freebsd.org/D29850 has my attempt to do the latter. Please comment there... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoAr9YLiPObfKaYVrprat%2BZotzwqhy1kfideXoJouA8OA>