Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 May 2026 20:15:08 +0000
From:      Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav <des@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 40c846dc0794 - main - uart: Tidy the compat tables
Message-ID:  <6a1750cc.1de87.5904db4@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by des:

URL: https://cgit.FreeBSD.org/src/commit/?id=40c846dc07943df7cdebf091de09d5680a3f3606

commit 40c846dc07943df7cdebf091de09d5680a3f3606
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2026-05-27 20:14:58 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2026-05-27 20:14:58 +0000

    uart: Tidy the compat tables
    
    No functional change intended.
    
    MFC after:      1 week
    Sponsored by:   Klara, Inc.
    Sponsored by:   NetApp, Inc.
    Reviewed by:    royger
    Differential Revision:  https://reviews.freebsd.org/D57269
---
 sys/dev/uart/uart_dev_ns8250.c | 44 +++++++++++++++++++++---------------------
 sys/dev/uart/uart_dev_pl011.c  | 30 ++++++++++++++--------------
 2 files changed, 37 insertions(+), 37 deletions(-)

diff --git a/sys/dev/uart/uart_dev_ns8250.c b/sys/dev/uart/uart_dev_ns8250.c
index c13eabe9055e..d6940dc80005 100644
--- a/sys/dev/uart/uart_dev_ns8250.c
+++ b/sys/dev/uart/uart_dev_ns8250.c
@@ -529,40 +529,40 @@ UART_CLASS(uart_ns8250_class);
  */
 #ifdef DEV_ACPI
 static struct acpi_spcr_compat_data acpi_spcr_compat_data[] = {
-	{ &uart_ns8250_class, ACPI_DBG2_16550_COMPATIBLE },
-	{ &uart_ns8250_class, ACPI_DBG2_16550_SUBSET },
-	{ &uart_ns8250_class, ACPI_DBG2_16550_WITH_GAS },
+	{ &uart_ns8250_class,	ACPI_DBG2_16550_COMPATIBLE },
+	{ &uart_ns8250_class,	ACPI_DBG2_16550_SUBSET },
+	{ &uart_ns8250_class,	ACPI_DBG2_16550_WITH_GAS },
 	{ NULL, 0 },
 };
 UART_ACPI_SPCR_CLASS(acpi_spcr_compat_data);
 
 static struct acpi_uart_compat_data acpi_compat_data[] = {
 	{"AMD0020",	&uart_ns8250_class, 2, 0, 48000000, UART_F_BUSY_DETECT, "AMD / Synopsys Designware UART"},
-	{"AMDI0020", &uart_ns8250_class, 2, 0, 48000000, UART_F_BUSY_DETECT, "AMD / Synopsys Designware UART"},
-	{"APMC0D08", &uart_ns8250_class, 2, 4, 0, 0, "APM compatible UART"},
-	{"MRVL0001", &uart_ns8250_class, 2, 0, 200000000, UART_F_BUSY_DETECT, "Marvell / Synopsys Designware UART"},
-	{"SCX0006",  &uart_ns8250_class, 2, 0, 62500000, UART_F_BUSY_DETECT, "SynQuacer / Synopsys Designware UART"},
-	{"HISI0031", &uart_ns8250_class, 2, 0, 200000000, UART_F_BUSY_DETECT, "HiSilicon / Synopsys Designware UART"},
-	{"INTC1006", &uart_ns8250_class, 2, 0, 25000000, 0, "Intel ARM64 UART"},
-	{"NXP0018", &uart_ns8250_class, 0, 0, 350000000, UART_F_BUSY_DETECT, "NXP / Synopsys Designware UART"},
-	{"PNP0500", &uart_ns8250_class, 0, 0, 0, 0, "Standard PC COM port"},
-	{"PNP0501", &uart_ns8250_class, 0, 0, 0, 0, "16550A-compatible COM port"},
-	{"PNP0502", &uart_ns8250_class, 0, 0, 0, 0, "Multiport serial device (non-intelligent 16550)"},
-	{"PNP0510", &uart_ns8250_class, 0, 0, 0, 0, "Generic IRDA-compatible device"},
-	{"PNP0511", &uart_ns8250_class, 0, 0, 0, 0, "Generic IRDA-compatible device"},
-	{"WACF004", &uart_ns8250_class, 0, 0, 0, 0, "Wacom Tablet PC Screen"},
-	{"WACF00E", &uart_ns8250_class, 0, 0, 0, 0, "Wacom Tablet PC Screen 00e"},
-	{"FUJ02E5", &uart_ns8250_class, 0, 0, 0, 0, "Wacom Tablet at FuS Lifebook T"},
-	{NULL, 			NULL, 0 , 0, 0, 0, NULL},
+	{"AMDI0020",	&uart_ns8250_class, 2, 0, 48000000, UART_F_BUSY_DETECT, "AMD / Synopsys Designware UART"},
+	{"APMC0D08",	&uart_ns8250_class, 2, 4, 0, 0, "APM compatible UART"},
+	{"MRVL0001",	&uart_ns8250_class, 2, 0, 200000000, UART_F_BUSY_DETECT, "Marvell / Synopsys Designware UART"},
+	{"SCX0006", 	&uart_ns8250_class, 2, 0, 62500000, UART_F_BUSY_DETECT, "SynQuacer / Synopsys Designware UART"},
+	{"HISI0031",	&uart_ns8250_class, 2, 0, 200000000, UART_F_BUSY_DETECT, "HiSilicon / Synopsys Designware UART"},
+	{"INTC1006",	&uart_ns8250_class, 2, 0, 25000000, 0, "Intel ARM64 UART"},
+	{"NXP0018",	&uart_ns8250_class, 0, 0, 350000000, UART_F_BUSY_DETECT, "NXP / Synopsys Designware UART"},
+	{"PNP0500",	&uart_ns8250_class, 0, 0, 0, 0, "Standard PC COM port"},
+	{"PNP0501",	&uart_ns8250_class, 0, 0, 0, 0, "16550A-compatible COM port"},
+	{"PNP0502",	&uart_ns8250_class, 0, 0, 0, 0, "Multiport serial device (non-intelligent 16550)"},
+	{"PNP0510",	&uart_ns8250_class, 0, 0, 0, 0, "Generic IRDA-compatible device"},
+	{"PNP0511",	&uart_ns8250_class, 0, 0, 0, 0, "Generic IRDA-compatible device"},
+	{"WACF004",	&uart_ns8250_class, 0, 0, 0, 0, "Wacom Tablet PC Screen"},
+	{"WACF00E",	&uart_ns8250_class, 0, 0, 0, 0, "Wacom Tablet PC Screen 00e"},
+	{"FUJ02E5",	&uart_ns8250_class, 0, 0, 0, 0, "Wacom Tablet at FuS Lifebook T"},
+	{NULL, 		NULL,		    0, 0, 0, 0, NULL},
 };
 UART_ACPI_CLASS_AND_DEVICE(acpi_compat_data);
 #endif
 
 #ifdef FDT
 static struct ofw_compat_data compat_data[] = {
-	{"ns16550",		(uintptr_t)&uart_ns8250_class},
-	{"ns16550a",		(uintptr_t)&uart_ns8250_class},
-	{NULL,			(uintptr_t)NULL},
+	{"ns16550",	(uintptr_t)&uart_ns8250_class},
+	{"ns16550a",	(uintptr_t)&uart_ns8250_class},
+	{NULL,		(uintptr_t)NULL},
 };
 UART_FDT_CLASS_AND_DEVICE(compat_data);
 #endif
diff --git a/sys/dev/uart/uart_dev_pl011.c b/sys/dev/uart/uart_dev_pl011.c
index ae3c4d3218cf..f0d7bcda1fa4 100644
--- a/sys/dev/uart/uart_dev_pl011.c
+++ b/sys/dev/uart/uart_dev_pl011.c
@@ -382,32 +382,32 @@ static struct uart_class uart_pl011_class = {
 };
 UART_CLASS(uart_pl011_class);
 
-#ifdef FDT
-static struct ofw_compat_data fdt_compat_data[] = {
-	{"arm,pl011",		(uintptr_t)&uart_pl011_class},
-	{NULL,			(uintptr_t)NULL},
-};
-UART_FDT_CLASS_AND_DEVICE(fdt_compat_data);
-#endif
-
 #ifdef DEV_ACPI
 static struct acpi_spcr_compat_data acpi_spcr_compat_data[] = {
-	{ &uart_pl011_class, ACPI_DBG2_ARM_PL011 },
-	{ &uart_pl011_class, ACPI_DBG2_ARM_SBSA_GENERIC },
-	{ &uart_pl011_class, ACPI_DBG2_ARM_SBSA_32BIT },
+	{ &uart_pl011_class,	ACPI_DBG2_ARM_PL011 },
+	{ &uart_pl011_class,	ACPI_DBG2_ARM_SBSA_GENERIC },
+	{ &uart_pl011_class,	ACPI_DBG2_ARM_SBSA_32BIT },
 	{ NULL, 0 },
 };
 UART_ACPI_SPCR_CLASS(acpi_spcr_compat_data);
 
 static struct acpi_uart_compat_data acpi_compat_data[] = {
-	{"ARMH0011", &uart_pl011_class, 2, 0, 0, 0, "uart pl011"},
-	{"ARMHB000", &uart_pl011_class, 2, 0, 0, 0, "uart pl011"},
-	{"ARMHB000", &uart_pl011_class, 2, 0, 0, 0, "uart pl011"},
-	{NULL, NULL, 0, 0, 0, 0, NULL},
+	{"ARMH0011",	&uart_pl011_class, 2, 0, 0, 0, "uart pl011"},
+	{"ARMHB000",	&uart_pl011_class, 2, 0, 0, 0, "uart pl011"},
+	{"ARMHB000",	&uart_pl011_class, 2, 0, 0, 0, "uart pl011"},
+	{NULL,		NULL,		   0, 0, 0, 0, NULL},
 };
 UART_ACPI_CLASS_AND_DEVICE(acpi_compat_data);
 #endif
 
+#ifdef FDT
+static struct ofw_compat_data fdt_compat_data[] = {
+	{"arm,pl011",	(uintptr_t)&uart_pl011_class},
+	{NULL,		(uintptr_t)NULL},
+};
+UART_FDT_CLASS_AND_DEVICE(fdt_compat_data);
+#endif
+
 static int
 uart_pl011_bus_attach(struct uart_softc *sc)
 {


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a1750cc.1de87.5904db4>