Date: Wed, 13 May 2026 12:39:54 +0000 From: Olivier Certner <olce@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 0813dc032547 - main - acpi_spmc(4): In-kernel strdup() cannot fail, remove dead code Message-ID: <6a04711a.1a621.8ae3d91@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=0813dc0325476599841268f405d4bce8b341b2db commit 0813dc0325476599841268f405d4bce8b341b2db Author: Olivier Certner <olce@FreeBSD.org> AuthorDate: 2026-05-04 19:41:14 +0000 Commit: Olivier Certner <olce@FreeBSD.org> CommitDate: 2026-05-13 12:38:22 +0000 acpi_spmc(4): In-kernel strdup() cannot fail, remove dead code No functional change (intended). Reviewed by: imp, obiwac Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D56814 --- sys/dev/acpica/acpi_spmc.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c index fde803bdd15d..95d802f7688d 100644 --- a/sys/dev/acpica/acpi_spmc.c +++ b/sys/dev/acpica/acpi_spmc.c @@ -508,10 +508,6 @@ acpi_spmc_parse_constraints_intel(struct acpi_spmc_softc *sc, ACPI_OBJECT *objec name_obj = &constraint_obj->Package.Elements[0]; constraint->name = strdup(name_obj->String.Pointer, M_TEMP); - if (constraint->name == NULL) { - acpi_spmc_free_constraints(sc); - return (ENOMEM); - } detail = &constraint_obj->Package.Elements[2]; /* @@ -582,10 +578,6 @@ acpi_spmc_parse_constraints_amd(struct acpi_spmc_softc *sc, ACPI_OBJECT *object) name_obj = &constraint_obj->Package.Elements[1]; constraint->name = strdup(name_obj->String.Pointer, M_TEMP); - if (constraint->name == NULL) { - acpi_spmc_free_constraints(sc); - return (ENOMEM); - } constraint->function_states = constraint_obj->Package.Elements[2].Integer.Value;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a04711a.1a621.8ae3d91>
