Date: Wed, 4 Jul 2018 16:31:04 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Cy Schubert <Cy.Schubert@cschubert.com>, Matt Macy <mmacy@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335919 - head/sys/netinet6 Message-ID: <13fa004f-6d8a-025e-9d4f-957f081113b4@yandex.ru> In-Reply-To: <201807041305.w64D5qiK002898@slippy.cwsent.com> References: <201807041305.w64D5qiK002898@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--DYq4DERiQq8E3pDWhQQJu3pRxNkEa3XRw
Content-Type: multipart/mixed; boundary="3UyYmNTJPMJYH4JeWdQTZY41T0JnKZ9UW";
protected-headers="v1"
From: "Andrey V. Elsukov" <bu7cher@yandex.ru>
To: Cy Schubert <Cy.Schubert@cschubert.com>, Matt Macy <mmacy@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
svn-src-head@freebsd.org
Message-ID: <13fa004f-6d8a-025e-9d4f-957f081113b4@yandex.ru>
Subject: Re: svn commit: r335919 - head/sys/netinet6
References: <201807041305.w64D5qiK002898@slippy.cwsent.com>
In-Reply-To: <201807041305.w64D5qiK002898@slippy.cwsent.com>
--3UyYmNTJPMJYH4JeWdQTZY41T0JnKZ9UW
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 04.07.2018 16:05, Cy Schubert wrote:
> Hi Matt,
>=20
> This is causing a panic of my gateway machine. Likely due to router=20
> solicitations.
Hi,
probably in the last two chunks "inp" should be replaced with "last"
Index: udp6_usrreq.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- udp6_usrreq.c (revision 335934)
+++ udp6_usrreq.c (working copy)
@@ -387,7 +387,7 @@ udp6_input(struct mbuf **mp, int *offp, int proto)
if ((n =3D m_copym(m, 0, M_COPYALL, M_NOWAIT)) !=3D
NULL) {
INP_RLOCK(last);
- if (__predict_true(inp->inp_flags2 & INP_FREED) =3D=3D 0) {
+ if (__predict_true(last->inp_flags2 & INP_FREED) =3D=3D 0) {
UDP_PROBE(receive, NULL, last, ip6,
last, uh);
if (udp6_append(last, n, off, fromsa))
@@ -421,7 +421,7 @@ udp6_input(struct mbuf **mp, int *offp, int proto)
goto badheadlocked;
}
INP_RLOCK(last);
- if (__predict_true(inp->inp_flags2 & INP_FREED) =3D=3D 0) {
+ if (__predict_true(last->inp_flags2 & INP_FREED) =3D=3D 0) {
UDP_PROBE(receive, NULL, last, ip6, last, uh);
if (udp6_append(last, m, off, fromsa) =3D=3D 0)
INP_RUNLOCK(last);
--=20
WBR, Andrey V. Elsukov
--3UyYmNTJPMJYH4JeWdQTZY41T0JnKZ9UW--
--DYq4DERiQq8E3pDWhQQJu3pRxNkEa3XRw
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAls8zBgACgkQAcXqBBDI
oXpnJwf/ZG+4ubzE/aIyOTWkmt9F0H3oXDsQmJurDT4Eo7okLFaFcXqFqnjJU06I
wKeiqb/h537MZB1qwmk4LK44DEliepAkJ6bpx1Wo/+z3d5gT3Z7HVssB0Asq0lHd
BZO8WDmqovI1aajUsTMr4bkhutzB1juPU+aWrvk70N9nSbp8WC2DGShx3RdUQVvb
t9pL4FrMsBV4JTSFj96iulKqTwaoDAS8mZSmbd4ONiawZ1kVd50EA70dxL/qWpcC
BiSbrTv1qfDRc2oofDkHkQipGXayN4+CWCsH9DvLGxLIyyeL1oaDyQxnt5R6Uw39
6nuLtodHpt+QFJLz5xFk+iQlARIfGw==
=Ci2t
-----END PGP SIGNATURE-----
--DYq4DERiQq8E3pDWhQQJu3pRxNkEa3XRw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13fa004f-6d8a-025e-9d4f-957f081113b4>