Date: Thu, 09 Sep 2010 15:38:02 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Koop Mast <kwm@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/multimedia/webcamd Makefile distinfo ports/multimedia/webcamd/files webcamd.conf.in webcamd.in Message-ID: <4C8961CA.5090402@FreeBSD.org> In-Reply-To: <201009091436.o89Ea4nO085960@repoman.freebsd.org> References: <201009091436.o89Ea4nO085960@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
There are 2 problems with the change in this patch. First, we prefer not to run code unconditionally in rc.d scripts, the hald_enable test should be in a start_precmd method. Second, testing for the existence of hald_enable is not sufficient, it could be set as "hald_enable=NO". The proper test is to use the rc.subr checkyesno function. hth, Doug On 9/9/2010 7:36 AM, Koop Mast wrote: > kwm 2010-09-09 14:36:04 UTC > > FreeBSD ports repository > > Modified files: > multimedia/webcamd Makefile distinfo > multimedia/webcamd/files webcamd.conf.in webcamd.in > Log: > Update to 0.1.16. > > - Add support for GNU/kFreeBSD > - Add support for DBUS/HAL registration > - Add support for more DVB tuner frontends > - Add support for multi-antenna DVB adapters > - Update to latest version of Linux DVB code > > Submitted by: maintainer > > Revision Changes Path > 1.8 +17 -2 ports/multimedia/webcamd/Makefile > 1.7 +3 -3 ports/multimedia/webcamd/distinfo > 1.4 +1 -1 ports/multimedia/webcamd/files/webcamd.conf.in > 1.4 +8 -2 ports/multimedia/webcamd/files/webcamd.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/webcamd/Makefile.diff?&r1=1.7&r2=1.8&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/webcamd/distinfo.diff?&r1=1.6&r2=1.7&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/webcamd/files/webcamd.conf.in.diff?&r1=1.3&r2=1.4&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/multimedia/webcamd/files/webcamd.in.diff?&r1=1.3&r2=1.4&f=h > -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C8961CA.5090402>