Date: Sun, 11 Sep 2011 16:28:07 +0000 (UTC) From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r225478 - user/adrian/if_ath_tx/sys/dev/ath Message-ID: <201109111628.p8BGS7xX086134@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: adrian Date: Sun Sep 11 16:28:07 2011 New Revision: 225478 URL: http://svn.freebsd.org/changeset/base/225478 Log: Just add a little warning if NOACK tagged frames end up in an aggregate queue, and disable NOACK for now. I'll worry about fixing this up at some point in the future. Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx_ht.c Modified: user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx_ht.c ============================================================================== --- user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx_ht.c Sun Sep 11 16:20:59 2011 (r225477) +++ user/adrian/if_ath_tx/sys/dev/ath/if_ath_tx_ht.c Sun Sep 11 16:28:07 2011 (r225478) @@ -758,6 +758,17 @@ ath_tx_form_aggr(struct ath_softc *sc, s */ /* + * XXX enforce ACK for aggregate frames (this needs to be + * XXX handled more gracefully? + */ + if (bf->bf_state.bfs_flags & HAL_TXDESC_NOACK) { + device_printf(sc->sc_dev, + "%s: HAL_TXDESC_NOACK set for an aggregate frame?\n", + __func__); + bf->bf_state.bfs_flags &= (~HAL_TXDESC_NOACK); + } + + /* * Add the now owned buffer (which isn't * on the software TXQ any longer) to our * aggregate frame list.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109111628.p8BGS7xX086134>