Date: Tue, 16 Oct 2007 17:26:31 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Alexander Leidinger <netchild@FreeBSD.org> Cc: Wilko Bulte <wb@freebie.xs4all.nl>, Poul-Henning Kamp <phk@phk.freebsd.dk>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5 rc.conf.5 src/share/man/man9 Makefile sensor_attach.9 src/sys/conf files ... Message-ID: <200710161726.32718.jhb@freebsd.org> In-Reply-To: <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net> References: <1947.1192477927@critter.freebsd.dk> <20071016183311.lu97hbwzggsk4ow4@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 16 October 2007 12:33:11 pm Alexander Leidinger wrote: > Constantine asked for review several times on -current. He got some > reviews several times for commits to perforce. He incorporated > suggestions from those reviews, or explained why it is like it is and > why he can not switch (with no replies with suggestions how to solve > the problems he sees with the suggestions). Now you come and ask why > nobody pointed out some flaws before (without telling us which > technical flaws you talk about). At least from my point of view this is not quite accurate as pretty much all my feedback to the p4 commits was ignored with basically "Well, I don't like doing it that way". Specifically, with regards to creating dynamic sysctl trees, Constantine feels that sysctl_add_oid(9) is a hack rather than recognizing that this is a feature of FreeBSD's sysctl system despite repeated e-mails on the subject. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710161726.32718.jhb>