Date: Mon, 16 Mar 2015 18:38:29 -0600 From: "Justin T. Gibbs" <gibbs@scsiguy.com> To: Alexander Motin <mav@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r280133 - head/usr.sbin/bhyve Message-ID: <6A7A51CE-9EAA-4F62-BECB-3CFDD708E06E@scsiguy.com> In-Reply-To: <201503160916.t2G9G01e095354@svn.freebsd.org> References: <201503160916.t2G9G01e095354@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mar 16, 2015, at 3:16 AM, Alexander Motin <mav@FreeBSD.org> wrote: > > Author: mav > Date: Mon Mar 16 09:15:59 2015 > New Revision: 280133 > URL: https://svnweb.freebsd.org/changeset/base/280133 > > Log: > Increase S/G list size of 32 to 33 entries. > > 32 entries are not enough for the worst case of misaligned 128KB request, > that made FreeBSD to chunk large quests in odd pieces. > > MFC after: 2 weeks > > Modified: > head/usr.sbin/bhyve/block_if.h > head/usr.sbin/bhyve/pci_virtio_block.c > > Modified: head/usr.sbin/bhyve/block_if.h > ============================================================================== > --- head/usr.sbin/bhyve/block_if.h Mon Mar 16 01:15:08 2015 (r280132) > +++ head/usr.sbin/bhyve/block_if.h Mon Mar 16 09:15:59 2015 (r280133) > @@ -39,7 +39,7 @@ > #include <sys/uio.h> > #include <sys/unistd.h> > > -#define BLOCKIF_IOV_MAX 32 /* not practical to be IOV_MAX */ > +#define BLOCKIF_IOV_MAX 33 /* not practical to be IOV_MAX */ Shouldn’t these be derived from MAXPHYS? — Justin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6A7A51CE-9EAA-4F62-BECB-3CFDD708E06E>