Date: Wed, 4 Nov 2009 12:10:03 GMT From: Tomokazu HARADA <tharada@oucrc.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/140251: [ata] [patch] add UDMA5 support to Intel SCH Message-ID: <200911041210.nA4CA3XH055479@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/140251; it has been noted by GNATS.
From: Tomokazu HARADA <tharada@oucrc.org>
To: bug-followup@FreeBSD.org
Cc: tharada@oucrc.org
Subject: Re: kern/140251: [ata] [patch] add UDMA5 support to Intel SCH
Date: Wed, 04 Nov 2009 20:39:29 +0900 (JST)
Previous patch is broken. Needs additional patch
--- ata-intel.c- 2009-11-04 00:38:25.000000000 +0900
+++ ata-intel.c 2009-11-04 20:36:01.000000000 +0900
@@ -394,14 +394,17 @@
if (!error) {
if (mode >= ATA_UDMA0) {
tim |= (0x1 << 31);
+ tim &= ~(0x7 << 16);
tim |= ((mode & ATA_MODE_MASK) << 16);
}
else if (mode >= ATA_WDMA0) {
tim &= ~(0x1 << 31);
+ tim &= ~(0x3 << 8);
tim |= ((mode & ATA_MODE_MASK) << 8);
}
else if (mode >= ATA_PIO0) {
- tim |= (mode - ATA_PIO0);
+ tim &= ~(0x7);
+ tim |= (mode & 0x7);
}
pci_write_config(gparent, dtim, tim, 4);
-----
Tomokazu HARADA
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911041210.nA4CA3XH055479>