Date: Wed, 29 Nov 2006 12:04:43 +0100 From: "Daan Vreeken [PA4DAN]" <Danovitsch@vitsch.net> To: Ian Dowse <iedowse@iedowse.com>, cvs-src@freebsd.org, "M. Warner Losh" <imp@bsdimp.com>, scottl@samsco.org, src-committers@freebsd.org, cvs-all@freebsd.org, marius@alchemy.franken.de Subject: Re: cvs commit: src/sys/dev/usb usbdi.c Message-ID: <200611291204.43704.Danovitsch@vitsch.net> In-Reply-To: <200611291058.aa80677@nowhere.iedowse.com> References: <200611291058.aa80677@nowhere.iedowse.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ian, On Wednesday 29 November 2006 11:58, you wrote: > In message <200611281453.26820.Danovitsch@vitsch.net>, "Daan Vreeken > [PA4DAN]" > > writes: > >I don't believe my patch is at the right place where it's placed now. Any > >ideas from someone with more bus_dma-foo and/or usb-foo are highly > >appreciated :) > >If more debugging information is needed, just ask. > > Hi Daan, > > Thanks for all the details - I'll try to put together a patch in the > next few days that adds bus_dmamap_sync() calls whereever there are > shared access ordering requirements in the host controller drivers. > As Olivier mentioned, bus_dma(9) says that this should be done even > for BUS_DMA_COHERENT allocations, so adding them may fix problems on > other platforms too. > > BTW it looks like some of the packet descriptor structures in the > HC drivers currently throw away their bus_dma information, since > the strutures are never freed, so adding the bus_dmamap_sync() calls > will involve keeping track of them now. Ok, thanks for looking into this! At the moment I'm working on a driver for the USB device port that's on the ARM board. The driver is about half way being usefull. Once it's finished I can debug USB problems from the device perspective and see what data actually goes over the wire. That should show us what exactly goes wrong without the bus_dmapmap_sync() calls. -- Daan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611291204.43704.Danovitsch>