Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Nov 2011 16:22:19 +0000 (UTC)
From:      Marius Strobl <marius@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r228027 - in head/sys: cam pc98/include pc98/pc98
Message-ID:  <201111271622.pARGMJdC046871@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marius
Date: Sun Nov 27 16:22:19 2011
New Revision: 228027
URL: http://svn.freebsd.org/changeset/base/228027

Log:
  Move the scsi_da_bios_params() prototype from pc98_machdep.h to md_var.h
  where the prototype for pc98_ata_disk_firmware_geom_adjust() also lives
  in order to avoid an #ifdef'ed include in cam(4).

Modified:
  head/sys/cam/cam_xpt.c
  head/sys/pc98/include/md_var.h
  head/sys/pc98/pc98/pc98_machdep.h

Modified: head/sys/cam/cam_xpt.c
==============================================================================
--- head/sys/cam/cam_xpt.c	Sun Nov 27 16:17:17 2011	(r228026)
+++ head/sys/cam/cam_xpt.c	Sun Nov 27 16:22:19 2011	(r228027)
@@ -48,10 +48,6 @@ __FBSDID("$FreeBSD$");
 #include <sys/sysctl.h>
 #include <sys/kthread.h>
 
-#ifdef PC98
-#include <pc98/pc98/pc98_machdep.h>	/* geometry translation */
-#endif
-
 #include <cam/cam.h>
 #include <cam/cam_ccb.h>
 #include <cam/cam_periph.h>

Modified: head/sys/pc98/include/md_var.h
==============================================================================
--- head/sys/pc98/include/md_var.h	Sun Nov 27 16:17:17 2011	(r228026)
+++ head/sys/pc98/include/md_var.h	Sun Nov 27 16:22:19 2011	(r228027)
@@ -39,10 +39,10 @@ extern	int	need_pre_dma_flush;
 extern	int	need_post_dma_flush;
 
 /*
- * The ad driver maps the IDE disk's actual geometry to the firmware's
- * notion of geometry.  However, PC98 machines need to do something
- * different sometimes, so override the hook so we can do so.
+ * The geometry of disks might need adjustment on PC98 machines.
  */
+struct	ccb_calc_geometry;
+int	scsi_da_bios_params(struct ccb_calc_geometry *);
 struct disk;
 void	pc98_ata_disk_firmware_geom_adjust(struct disk *);
 #define	ata_disk_firmware_geom_adjust(disk)				\

Modified: head/sys/pc98/pc98/pc98_machdep.h
==============================================================================
--- head/sys/pc98/pc98/pc98_machdep.h	Sun Nov 27 16:17:17 2011	(r228026)
+++ head/sys/pc98/pc98/pc98_machdep.h	Sun Nov 27 16:22:19 2011	(r228027)
@@ -33,9 +33,6 @@
 void	pc98_init_dmac(void);
 unsigned int	pc98_getmemsize(unsigned *, unsigned *);
 
-struct	ccb_calc_geometry;
-int	scsi_da_bios_params(struct ccb_calc_geometry *);
-
 #define	PC98_VECTOR_SIZE			(0x400)
 #define	PC98_SYSTEM_PARAMETER_SIZE		(0x240)
 #define	PC98_SAVE_AREA				(0xa1000)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201111271622.pARGMJdC046871>