Date: Thu, 8 Nov 2007 11:40:51 +0100 From: Anton Berezin <tobez@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/117916: Mk/bsd.port.mk: Reversed condition for setting --no-same-owner in extract Message-ID: <20071108104051.GC33233@heechee.tobez.org> In-Reply-To: <200711081000.lA8A07aF008228@freefall.freebsd.org> References: <20071108094255.ED13C12542E@heechee.tobez.org> <200711081000.lA8A07aF008228@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I would like to add that fixing this will probably make unnecessary code in
do-extract that does chmod/chown after extracting:
--- bsd.port.mk.orig2 2007-11-08 11:38:11.000000000 +0100
+++ bsd.port.mk 2007-11-08 11:38:17.000000000 +0100
@@ -3503,12 +3503,6 @@ do-extract:
exit 1; \
fi; \
done
-.if !defined(EXTRACT_PRESERVE_OWNERSHIP)
- @if [ `${ID} -u` = 0 ]; then \
- ${CHMOD} -R ug-s ${WRKDIR}; \
- ${CHOWN} -R 0:0 ${WRKDIR}; \
- fi
-.endif
.endif
# Patch
--
We're going for 'working' here. 'clean' is for people with skills...
-- Flemming Jacobsen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071108104051.GC33233>