Date: Tue, 30 Jul 2013 11:50:34 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Dag-Erling =?unknown-8bit?B?U23DuHJncmF2?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r253786 - in head/sys: dev/random modules/padlock_rng modules/rdrand_rng modules/yarrow_rng Message-ID: <20130730185034.GA63635@dragon.NUXI.org> In-Reply-To: <86fvuwgrs6.fsf@nine.des.no> References: <201307292058.r6TKwA56031193@svn.freebsd.org> <86fvuwgrs6.fsf@nine.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 30, 2013 at 02:23:53PM +0200, Dag-Erling Smrgrav wrote: > "David E. O'Brien" <obrien@FreeBSD.org> writes: > > Log: > > Decouple yarrow from random(4) device. > > We've had a policy for several years now that all changes to the PRNG > code in the kernel and libc must be reviewed by so@. Hi DES, Where was this policy published or communicated? There is no MAINTAINER line in sys/dev/random/, nor an entry in /usr/src/MAINTAINERS. It is hard to follow some policy that cannot be found. > Please revert > this commit and submit your patch to secteam@freebsd.org for review. There was a lot of work put into this patch. 'make tenderbox', and much boot testing of various kernel configs on both i386, amd64, both IvyBridge and non-IvyBridge systems, ARM (Beaglebone) with both statically compiled in random(4) and loaded via modules. This change does not change any of the PRNG algorithms. Please see if you cannot review the code within the tree with doing a whiplash backout-recommit. Do you have any specific concerns? -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130730185034.GA63635>