Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Jan 2011 00:27:34 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r218115 - stable/8/sys/dev/alc
Message-ID:  <201101310027.p0V0RYuG091703@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: yongari
Date: Mon Jan 31 00:27:34 2011
New Revision: 218115
URL: http://svn.freebsd.org/changeset/base/218115

Log:
   MFC r218038:
    Fix logic error. Due to the bug, it incorrectly checked TXQ status
    which in turn can leave TXQ active.
  
    Submitted by:	Brad ( brad <> comstyle dot com )

Modified:
  stable/8/sys/dev/alc/if_alc.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)

Modified: stable/8/sys/dev/alc/if_alc.c
==============================================================================
--- stable/8/sys/dev/alc/if_alc.c	Mon Jan 31 00:09:52 2011	(r218114)
+++ stable/8/sys/dev/alc/if_alc.c	Mon Jan 31 00:27:34 2011	(r218115)
@@ -3558,7 +3558,7 @@ alc_stop_queue(struct alc_softc *sc)
 	}
 	/* Disable TxQ. */
 	reg = CSR_READ_4(sc, ALC_TXQ_CFG);
-	if ((reg & TXQ_CFG_ENB) == 0) {
+	if ((reg & TXQ_CFG_ENB) != 0) {
 		reg &= ~TXQ_CFG_ENB;
 		CSR_WRITE_4(sc, ALC_TXQ_CFG, reg);
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101310027.p0V0RYuG091703>