Date: Thu, 20 Nov 2014 10:23:38 -0700 From: Warner Losh <imp@bsdimp.com> To: "Andrey V. Elsukov" <ae@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Warner Losh <imp@FreeBSD.org> Subject: Re: svn commit: r274661 - in head/sys: conf geom/part modules/geom/geom_part/geom_part_bsd Message-ID: <6A0453EA-0DAC-4901-AF29-F75E2787B76A@bsdimp.com> In-Reply-To: <546E08BA.1020707@FreeBSD.org> References: <201411181706.sAIH6eS9051888@svn.freebsd.org> <546CC245.3070700@FreeBSD.org> <B523D699-9766-4806-9499-68FD9FF84437@bsdimp.com> <546CDABC.9020103@FreeBSD.org> <AC547D14-AE9E-4E26-9844-B8B6E7C0050D@bsdimp.com> <546E08BA.1020707@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Nov 20, 2014, at 8:28 AM, Andrey V. Elsukov <ae@FreeBSD.org> wrote: > On 19.11.2014 21:49, Warner Losh wrote: >> >> On Nov 19, 2014, at 11:00 AM, Andrey V. Elsukov <ae@FreeBSD.org> wrote: >> >>> On 19.11.2014 19:20, Warner Losh wrote: >>>>> Probably you need to use basetable->gpt_entries here instead of >>>>> MAXPARTITIONS. >>>> >>>> I’m having trouble connecting the dots between GPT and BSDlabels. Why >>>> would this field be relevant? Is it just poorly named? MAXPARTITIONS >>> >>> gpt_entries isn't related to GPT, it is `geom partition table's` number >>> of partitions entries. Each instance of partition table (i.e. geom) can >>> have own number of partitions. MBR always has 4, but GPT or BSD can have >>> different numbers. >> >> Ah, OK. Thanks for the explanation. I understand. I’ll work up a patch. > > Hi, Warner > > since there are some reports about strange behavior of old utilities > after this commit, maybe we won't repair them by this way? > What you think about this path? It doesn’t thrill me. What’s it trying to do? And localizing it to fsck is useless. And where are these reports? Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUbiOaAAoJEGwc0Sh9sBEAo0IP/Ajsfkf5WK3202Ob/awWVdhT nqRN31xOgItgwdcTHSNsHQaGKn3GmxEGWO8EROGhtD5FzxyHADMZU+lJ/xgxN4lo ICfWEUnWvWm06J45qlZLQPUlPpjR/Q2Pr6pIy0JtDHNEBWLtoNsyAhPZZGKzA/IL hPakHQh4DCLnfwoAwL0UHQsdNi95LpDHdRT8GuTpF30Z8kCE4sN4Xffz5YIO0Cmk jWYbmz+L7FzDzgjubRmEL0y533WMr5Q/GYR2MX2dwk9Gpcloaui/Z/ZZc+Z4KLe7 9NVq/VkqYTFjAj75xu9Ykfi51vLUFvThhL3GRZsSFyTiYRqKa6osXHd7WMfk79Sa yiFSD3FLSGcLV0I75AC+vUoNqzctj4z2ituGM27EnZS6XZ4ap/PvC0rLhjkZR7uy jnGov1kRtWZhcD4AN1UfyhLhUZykQv+WI0FDRVgdgIhpkpLzAVi0xLY3vGY+nJJY 3A4+T9RP9nbPYQRe5xvfkbmQ617AlhR7G4F4YngVuH3odpFm9LKcyik72k/b6lag HYrmNdIeU5joDNJCeByNtahx6tgm6ivpfy4Kcm8ZDGsiBNb5tRylgX/RCvH4aQR6 J8uHVtHIhwGb1An+IisgLzjgizR0ynUqhVg3MJifJly2ZXQHavCpG1y7+ICXE+OZ 10Ga1XKHfjJrqodxNK6a =/TOi -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6A0453EA-0DAC-4901-AF29-F75E2787B76A>