Date: Tue, 15 Dec 2015 02:21:26 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 205328] devel/oniguruma5: Use GITHUB for DISTFILES Message-ID: <bug-205328-13-7STNpIEqDQ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-205328-13@https.bugs.freebsd.org/bugzilla/> References: <bug-205328-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205328 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|UPDATE: devel/oniguruma5 to |devel/oniguruma5: Use |use github |GITHUB for DISTFILES CC| |koobs@FreeBSD.org Keywords| |easy, needs-qa, patch --- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> --- Thanks for your submission Robert. At least few further tweaks are needed: * GH_PROJECT is PORTNAME by default, you can remove this * For GH_TAGNAME, if the repository has git tags, please use them instead of commit hashes. Note: GH_TAGNAME defaults to PORTVERSION already * INSTALL_TARGET=install-strip shouldn't be removed without good reason. * You should be able to use USES=pathfix instead of: @${REINPLACE_CMD} -e 's|\$$(libdir)/pkgconfig| for CMakeLists.txt and Makefile.am Also, why are .so.* and onig-config not installed when using the github sources? Could you also please confirm this change passes QA (portlint, poudriere) -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-205328-13-7STNpIEqDQ>