Date: Fri, 21 Sep 2007 09:04:44 +0200 From: "=?UTF-8?Q?Petr_Hroudn=C3=BD?=" <petr.hroudny@gmail.com> To: "Andrey Chernov" <ache@nagual.pp.ru>, "Taku YAMAMOTO" <taku@tackymt.homeip.net>, "Petr Hroudn??" <petr.hroudny@gmail.com>, current@freebsd.org, perky@freebsd.org, i18n@freebsd.org Subject: Re: Ctype patch for review Message-ID: <ab8fc7f50709210004r2e823d2ex3a735d51e35e9360@mail.gmail.com> In-Reply-To: <20070921024107.GA21223@nagual.pp.ru> References: <20070916192924.GA12678@nagual.pp.ru> <20070917092130.GA24424@nagual.pp.ru> <20070918020100.d43beb0b.taku@tackymt.homeip.net> <20070917171633.GA31179@nagual.pp.ru> <20070919111207.f37653fc.taku@tackymt.homeip.net> <20070919022555.GA70617@nagual.pp.ru> <20070919023625.GA70891@nagual.pp.ru> <20070919051830.GA72429@nagual.pp.ru> <20070919121024.GA81606@nagual.pp.ru> <20070921024107.GA21223@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
2007/9/21, Andrey Chernov <ache@nagual.pp.ru>: > On Wed, Sep 19, 2007 at 04:10:24PM +0400, Andrey Chernov wrote: > > Improved vesrsion. Intoduce general __mb_sch_limit parameter instead for > > all locales specifying upper limit of single char range. It allows also > > fix the bug when ctype(3) functions called with arg > 0xFF for wide > > character locales and simplifies all checks. New patch is attached. Here > > is updated rationale again: > > Next improved version, now optimized for speed. I decide to remove extra > _CTYPE_WID flag and duplicate needed functions instead. I believe your patch needs some adjustments for CJK charsets. You are setting __mb_sch_limit to 256 for all multibyte locales except UTF-8, but I believe it should be 128 also for Big5, GB18030, GBK. Regards, Petr
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ab8fc7f50709210004r2e823d2ex3a735d51e35e9360>